DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix memory leak (#1167)

Browse Source 
Summary:
<img width="1126" alt="image" src="https://user-images.githubusercontent.com/14934570/195335369-e3fccde7-ff6c-4437-a261-7bc7435143c2.png">

`root_child0` be removed by`YGNodeRemoveChild(root, root_child0);`
so `YGNodeFreeRecursive(root);` can not free `root_child0`

Pull Request resolved: https://github.com/facebook/yoga/pull/1167

Reviewed By: NickGerleman, cipolleschi

Differential Revision: D40298891

Pulled By: motiz88

fbshipit-source-id: 251d3b3decfbd102372a7afeb2e95c907f96a980
This commit is contained in:
simonla
2022-10-12 08:09:34 -07:00
committed by Facebook GitHub Bot
parent 260e60b4b1
commit 1daed063f3
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/YGNodeChildTest.cpp
View File

@@ -31,4 +31,5 @@ TEST(YogaTest, reset_layout_when_child_removed) {
ASSERT_TRUE(YGFloatIsUndefined(YGNodeLayoutGetHeight(root_child0))); ASSERT_TRUE(YGFloatIsUndefined(YGNodeLayoutGetHeight(root_child0)));
YGNodeFreeRecursive(root); YGNodeFreeRecursive(root);
YGNodeFreeRecursive(root_child0);
} }