DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

No longer skip margin_start and margin_end row reverse tests

Browse Source 
Summary: These are fixed now!

Reviewed By: NickGerleman

Differential Revision: D50200030

fbshipit-source-id: ac3e80e33d8c35440e342a10cfd3246161ee9018
This commit is contained in:
Joe Vilches
2023-10-12 16:22:27 -07:00
committed by Facebook GitHub Bot
parent f4337fbb07
commit 3fbd92bc3b
4 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gentest/fixtures/YGFlexDirectionTest.html
View File

@@ -41,8 +41,7 @@
</div> </div>
<!-- gentest.rb will swap margin-start to margin-left. This is needed to use YGEdgeStart instead of YGEdgeLeft in the generated tests --> <!-- gentest.rb will swap margin-start to margin-left. This is needed to use YGEdgeStart instead of YGEdgeLeft in the generated tests -->
<!-- TODO: Yoga flips marginStart and marginEnd with rowReverse direction --> <div id="flex_direction_row_reverse_margin_start" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-start: 100px;">
<div id="flex_direction_row_reverse_margin_start" data-disabled="true" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-start: 100px;">
<div style="width: 10px;"></div> <div style="width: 10px;"></div>
<div style="width: 10px;"></div> <div style="width: 10px;"></div>
<div style="width: 10px;"></div> <div style="width: 10px;"></div>
@@ -54,8 +53,7 @@
<div style="width: 10px;"></div> <div style="width: 10px;"></div>
</div> </div>
<!-- TODO: Yoga flips marginStart and marginEnd with rowReverse direction --> <div id="flex_direction_row_reverse_margin_end" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-end: 100px;">
<div id="flex_direction_row_reverse_margin_end" data-disabled="true" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-end: 100px;">
<div style="width: 10px;"></div> <div style="width: 10px;"></div>
<div style="width: 10px;"></div> <div style="width: 10px;"></div>
<div style="width: 10px;"></div> <div style="width: 10px;"></div>

2
java/tests/com/facebook/yoga/YGFlexDirectionTest.java
View File

@@ -499,7 +499,6 @@ public class YGFlexDirectionTest {
} }
@Test @Test
@Ignore
public void test_flex_direction_row_reverse_margin_start() { public void test_flex_direction_row_reverse_margin_start() {
YogaConfig config = YogaConfigFactory.create(); YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true); config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -638,7 +637,6 @@ public class YGFlexDirectionTest {
} }
@Test @Test
@Ignore
public void test_flex_direction_row_reverse_margin_end() { public void test_flex_direction_row_reverse_margin_end() {
YogaConfig config = YogaConfigFactory.create(); YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true); config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);

4
javascript/tests/generated/YGFlexDirectionTest.test.ts
View File

@@ -540,7 +540,7 @@ test('flex_direction_row_reverse_margin_left', () => {
config.free(); config.free();
} }
}); });
test.skip('flex_direction_row_reverse_margin_start', () => { test('flex_direction_row_reverse_margin_start', () => {
const config = Yoga.Config.create(); const config = Yoga.Config.create();
let root; let root;
@@ -690,7 +690,7 @@ test('flex_direction_row_reverse_margin_right', () => {
config.free(); config.free();
} }
}); });
test.skip('flex_direction_row_reverse_margin_end', () => { test('flex_direction_row_reverse_margin_end', () => {
const config = Yoga.Config.create(); const config = Yoga.Config.create();
let root; let root;

4
tests/generated/YGFlexDirectionTest.cpp
View File

@@ -492,8 +492,6 @@ TEST(YogaTest, flex_direction_row_reverse_margin_left) {
} }
TEST(YogaTest, flex_direction_row_reverse_margin_start) { TEST(YogaTest, flex_direction_row_reverse_margin_start) {
GTEST_SKIP();
const YGConfigRef config = YGConfigNew(); const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true); YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
@@ -634,8 +632,6 @@ TEST(YogaTest, flex_direction_row_reverse_margin_right) {
} }
TEST(YogaTest, flex_direction_row_reverse_margin_end) { TEST(YogaTest, flex_direction_row_reverse_margin_end) {
GTEST_SKIP();
const YGConfigRef config = YGConfigNew(); const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true); YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);