fix breaking change in setMeasureFunc after emscripten migration (#1219)
Summary: current `MeasureFunc` is stricter than the previous one and when it returns only one dimension object yoga throw `TypeError: Missing field: "height"` or `TypeError: Missing field: "width"` this is a breaking change and `react-pdf` use this feature a lot, so i wanna return the previous behavior back codesandbox with reproduction on `yoga-layout-prebuilt`: https://codesandbox.io/s/yoga-layout-measure-callback-wrong-data-1l9133 Pull Request resolved: https://github.com/facebook/yoga/pull/1219 Reviewed By: NickGerleman Differential Revision: D42778696 Pulled By: jacdebug fbshipit-source-id: 2fb87be74f456ee34273655f2c47f62360001895
This commit is contained in:
committed by
Facebook GitHub Bot
parent
9e1bcd8557
commit
5496554cbf
@@ -74,11 +74,25 @@ module.exports = (lib) => {
|
||||
}
|
||||
|
||||
function wrapMeasureFunction(measureFunction) {
|
||||
return lib.MeasureCallback.implement({ measure: measureFunction });
|
||||
return lib.MeasureCallback.implement({
|
||||
measure: (...args) => {
|
||||
const { width, height } = measureFunction(...args);
|
||||
return {
|
||||
width: width ?? NaN,
|
||||
height: height ?? NaN,
|
||||
};
|
||||
},
|
||||
});
|
||||
}
|
||||
|
||||
patch(lib.Node.prototype, "setMeasureFunc", function (original, measureFunc) {
|
||||
original.call(this, wrapMeasureFunction(measureFunc));
|
||||
// This patch is just a convenience patch, since it helps write more
|
||||
// idiomatic source code (such as .setMeasureFunc(null))
|
||||
if (measureFunc) {
|
||||
return original.call(this, wrapMeasureFunction(measureFunc));
|
||||
} else {
|
||||
return this.unsetMeasureFunc();
|
||||
}
|
||||
});
|
||||
|
||||
function wrapDirtiedFunc(dirtiedFunction) {
|
||||
@@ -115,16 +129,6 @@ module.exports = (lib) => {
|
||||
this.free();
|
||||
});
|
||||
|
||||
patch(lib.Node.prototype, "setMeasureFunc", function (original, measureFunc) {
|
||||
// This patch is just a convenience patch, since it helps write more
|
||||
// idiomatic source code (such as .setMeasureFunc(null))
|
||||
if (measureFunc) {
|
||||
return original.call(this, (...args) => measureFunc(...args));
|
||||
} else {
|
||||
return this.unsetMeasureFunc();
|
||||
}
|
||||
});
|
||||
|
||||
patch(
|
||||
lib.Node.prototype,
|
||||
"calculateLayout",
|
||||
|
Reference in New Issue
Block a user