DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

guard against INF values in CompactValue

Browse Source 
Summary:
After this diff D13403925 that got rid of `-ffast-math` we started to have a very odd behavior on Yoga when using release builds.

After digging a while we found that certain set of conditions on O2 and O3 optimization levels was causing Origami to set some `INFINITE` values on Yoga.

We found the root of the problem and fix it on Origami side. But I'm wondering if guarding agains `INFINITE` on Yoga side would be good too. Since now Yoga it's not using `-ffast-math` anymore, and I think infinite is not a a valid value anywhere on Yoga side, it seems to support the reason to guard against it.

I'm happy to abandon this diff if you guys think this is not a good solution.

Reviewed By: davidaurelio

Differential Revision: D13679319

fbshipit-source-id: 061448fea9d1a8496362ff07dc46b546e7f1ffa3
This commit is contained in:
Eduardo Roman
2019-01-16 11:53:04 -08:00
committed by Facebook Github Bot
parent 71321f763a
commit 604a9a98a9
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/CompactValueTest.cpp
View File

@@ -29,6 +29,18 @@ TEST(YogaTest, compact_value_can_represent_undefined) {
ASSERT_FALSE(c.isAuto());
}
TEST(YogaTest, compact_value_manages_infinity_as_undefined) {
auto c = CompactValue{
YGValue{std::numeric_limits<float>::infinity(), YGUnitUndefined}};
YGValue v = c;
ASSERT_EQ(v, YGValueUndefined);
ASSERT_NE(v, YGValueAuto);
ASSERT_NE(v, (YGValue{-1.25, YGUnitPoint}));
ASSERT_NE(v, (YGValue{25, YGUnitPercent}));
ASSERT_TRUE(c.isUndefined());
ASSERT_FALSE(c.isAuto());
}
TEST(YogaTest, compact_value_can_represent_auto) {
auto c = CompactValue{YGValue{0, YGUnitAuto}};
YGValue v = c;

3
yoga/CompactValue.h
View File

@@ -70,7 +70,8 @@ public:
template <YGUnit Unit>
static CompactValue ofMaybe(float value) noexcept {
return std::isnan(value) ? ofUndefined() : of<Unit>(value);
return std::isnan(value) || std::isinf(value) ? ofUndefined()
: of<Unit>(value);
}
static constexpr CompactValue ofZero() noexcept {