Back out "[yoga][PR] Fix aspect ratio when stretching with main axis margin"

Summary: Original commit changeset: 6970e6072e79

Reviewed By: mdvacca

Differential Revision: D13437552

fbshipit-source-id: 65a55d716da6b6582e38efa906d3f540e58418bf

tests/YGAspectRatioTest.cpp

@@ -895,26 +895,3 @@ TEST(YogaTest, aspect_ratio_should_prefer_flexed_dimension) {
 
   YGNodeFreeRecursive(root);
 }
-
-TEST(
-    YogaTest,
-    aspect_ratio_defined_by_cross_stretch_should_not_be_effected_by_margin_on_main_axis) {
-  const YGConfigRef config = YGConfigNew();
-  YGConfigSetUseWebDefaults(config, true);
-
-  const YGNodeRef root = YGNodeNewWithConfig(config);
-  YGNodeStyleSetWidth(root, 200);
-  YGNodeStyleSetHeight(root, 100);
-
-  const YGNodeRef root_child0 = YGNodeNewWithConfig(config);
-  YGNodeStyleSetMargin(root_child0, YGEdgeStart, 50);
-  YGNodeStyleSetAspectRatio(root_child0, 1);
-  YGNodeInsertChild(root, root_child0, 0);
-
-  YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
-
-  ASSERT_EQ(100, YGNodeLayoutGetWidth(root_child0));
-  ASSERT_EQ(100, YGNodeLayoutGetHeight(root_child0));
-
-  YGNodeFreeRecursive(root);
-}

yoga/Yoga.cpp

@@ -1382,16 +1382,6 @@ static void YGNodeComputeFlexBasisForChild(
     auto marginColumn = YGUnwrapFloatOptional(
         child->getMarginForAxis(YGFlexDirectionColumn, ownerWidth));
 
-    if (YGNodeAlignItem(node, child) == YGAlignStretch) {
-      if (isMainAxisRow && !YGFloatIsUndefined(height)) {
-        childHeight = height;
-        childHeightMeasureMode = YGMeasureModeExactly;
-      } else if (!isMainAxisRow && !YGFloatIsUndefined(width)) {
-        childWidth = width;
-        childWidthMeasureMode = YGMeasureModeExactly;
-      }
-    }
-
     if (isRowStyleDimDefined) {
       childWidth =
           YGUnwrapFloatOptional(YGResolveValue(