DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Roll back -ffast-math

Browse Source 
Summary:
@public

`-ffast-math` does not have measurable performance benefits.

By using `NaN` for *undefined* values again, we can squeeze `YGFloatOptional` into 32 bits.
This will also enable us to store `YGValue` (or a variant of it) in 32 bits.

Reviewed By: astreet

Differential Revision: D13403925

fbshipit-source-id: b13d026bf556f24ab4699e65fb450af13a70961b
This commit is contained in:
David Aurelio
2018-12-13 07:09:28 -08:00
committed by Facebook Github Bot
parent 8ab01fde6e
commit 9ddda3c630
7 changed files with 21 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
yoga/Yoga.cpp
View File

@@ -18,10 +18,7 @@
/* define fmaxf if < VC12 */
#if _MSC_VER < 1800
__forceinline const float fmaxf(const float a, const float b) {
if (!YGFloatIsUndefined(a) && !YGFloatIsUndefined(b)) {
return (a > b) ? a : b;
}
return YGFloatIsUndefined(a) ? b : a;
return (a > b) ? a : b;
}
#endif
#endif