Change how we set cmake policy (#1288)

Summary:
X-link: https://github.com/facebook/react-native/pull/37349

Pull Request resolved: https://github.com/facebook/yoga/pull/1288

Fixes https://github.com/facebook/yoga/issues/1283

New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`.

Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions.

Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392

This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum.

Reviewed By: cortinico

Differential Revision: D45724864

fbshipit-source-id: 120cc2015a043605e7c07ef0459667643a4284b7

This commit is contained in:

Nick Gerleman

2023-05-15 15:21:56 -07:00

committed by

Facebook GitHub Bot

parent 3fb698c08b

commit f2b4e42ca2

6 changed files with 6 additions and 7 deletions

									
										2

javascript/CMakeLists.txt
									
												View File
												
				@@ -3,7 +3,7 @@

				# This source code is licensed under the MIT license found in the

				# LICENSE file in the root directory of this source tree.

				cmake_minimum_required(VERSION 3.13)

				cmake_minimum_required(VERSION 3.13...3.26)

				set(CMAKE_VERBOSE_MAKEFILE on)

				project(yoga)

Change how we set cmake policy (#1288)

2 javascript/CMakeLists.txt Unescape Escape View File

2

javascript/CMakeLists.txt

View File