DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Mark some fields as readonly and reuse index value in RemoveChild

Browse Source 
Summary:
Mark some fields as readonly and reuse index value in RemoveChild.
Closes https://github.com/facebook/yoga/pull/516

Reviewed By: emilsjolander

Differential Revision: D4921809

Pulled By: splhack

fbshipit-source-id: 261a7910675d93be165c16ee53a83c02b15925f1
This commit is contained in:
Lukas Wöhrl
2017-04-25 11:27:29 -07:00
committed by Facebook Github Bot
parent 0684795a89
commit f2b5d0fef7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
csharp/Facebook.Yoga/YogaNode.cs
View File

@@ -26,8 +26,8 @@ namespace Facebook.Yoga
{ {
public partial class YogaNode : IEnumerable<YogaNode> public partial class YogaNode : IEnumerable<YogaNode>
{ {
private Native.YGNodeHandle _ygNode; private readonly Native.YGNodeHandle _ygNode;
private YogaConfig _config; private readonly YogaConfig _config;
private WeakReference _parent; private WeakReference _parent;
private List<YogaNode> _children; private List<YogaNode> _children;
private MeasureFunction _measureFunction; private MeasureFunction _measureFunction;
@@ -586,7 +586,7 @@ namespace Facebook.Yoga
int index = IndexOf(child); int index = IndexOf(child);
if (index >= 0) if (index >= 0)
{ {
RemoveAt(IndexOf(child)); RemoveAt(index);
} }
} }