Commit Graph

248 Commits

Author SHA1 Message Date
Jan Kassens
dda464cdb9 Fix getIframe test helper
Chrome seems to always be ready on the first iteration, so this doesn't affect
Chrome, but on Firefox, the `iframe` is undefined in the recursive call.

This makes most of the test in `RunLayoutTests.html` pass in Firefox. The only
failing test is the one checking font sizes.
2015-03-31 20:27:58 -07:00
Russell Keith-Magee
2b6844f00a Simplified logic distributing flex space. 2015-03-31 18:58:56 +08:00
Russell Keith-Magee
c523b7c404 Added support for min/max width and height constraints. 2015-03-31 17:32:54 +08:00
Tom Mulcahy
ddd7a899ac Make Java measure thread-safe. 2015-03-26 22:49:48 +00:00
Russell Keith-Magee
8f6a96adbc Normalized C and Java definition of isDimDefined.
The JavaScript implementation of isDimDefined contains a check to ensure
that the dimension value is positive; the C and Java versions did not
have this check. As a result, a negative style value for 'width' (such
as that used by the "should layout node with negative width" test) would
have different layout under the C/Java implementation to the JavaScript
implementation.

This was hidden because the C/Java transpilers filtered out any negative
instantiation values from the test suite. In effect, the negative value
tests weren't running on the C/Java implementation.

This patch removes the negative value filter from the transpiler, and
makes the isDimDefined definition consistent between the three
implementations.
2015-03-22 14:36:16 +08:00
daviskoh
9c71cc6d1f resolve merge conflicts 2015-02-17 21:30:41 -05:00
daviskoh
3a6e50db99 Address eslint errors:
* modify .eslintrc w/ globals & rules
* use judgement in deciding bet proj style & eslint recommendation
* make
2015-02-17 21:12:29 -05:00
daviskoh
4dc175dda4 replace jshint w/ eslint 2015-02-17 15:44:08 -05:00
Jimmy Miller
8fe8c15e6d Rework javascript api to match README 2015-02-15 20:56:37 -05:00
Alexander Gugel
b942b5ff60 Add UMD 2015-02-12 20:46:29 +01:00
daviskoh
55d6f9fba6 Merge branch 'master' into improvement/add-linter 2015-02-05 19:51:45 -05:00
daviskoh
cf9b841e33 Fix jshint issues
* add .jshintrc
* address semicolon errors
* ignore 'already defined' errors
2015-02-05 19:49:55 -05:00
Ryan Seddon
1ad94fa4e1 Fix firefox iframe timing issue, fixes #25 2015-02-05 21:14:19 +11:00
Christopher Chedeau
0e56641b28 Update font constants 2015-02-04 07:57:13 -08:00
Christopher Chedeau
5f8c3b0eb7 Update C version 2015-02-04 07:50:15 -08:00
Krzysztof Magiera
e1969bda05 Couple of major improvements for Java version.
Including:
 - Extracting spacing logic into a Spacing class
 - Fix layout update issue
 - Add null assertions support
2015-01-19 13:09:32 +00:00
Christopher Chedeau
d82ec0ddfd add bug reports urls for weird behaviors 2014-12-12 15:16:25 +00:00
Christopher Chedeau
1605bdfb1e add weird result from chrome 2014-12-12 13:14:18 +00:00
Christopher Chedeau
9001a3d2ac do not infinite loop when there's an element bigger than the container with flex-wrap 2014-12-12 12:24:26 +00:00
Christopher Chedeau
10fb645777 Initial implementation of flexWrap 2014-12-12 12:03:31 +00:00
Christopher Chedeau
28243156e4 make C and Java tests pass and update their code 2014-12-11 20:23:53 +00:00
Christopher Chedeau
e838124625 remove support for flex: 0 since chrome behavior is really weird 2014-12-11 16:52:38 +00:00
Christopher Chedeau
544f377f20 implement 1/64 rounding like chrome. Didn't add a test for it because this is Chrome specific and shouldn't be on ios and android 2014-12-11 16:31:57 +00:00
Christopher Chedeau
ab64a5b624 fix children with left 2014-12-11 15:58:45 +00:00
Christopher Chedeau
ba873aa3d7 fix layout border bottom and flex end with an empty child 2014-12-11 14:42:31 +00:00
Christopher Chedeau
79286e6263 fix positive margin top inside of justify content center container 2014-12-11 14:31:17 +00:00
Christopher Chedeau
570f7bf98a fix test case not passing because of div by 0 2014-12-11 14:22:04 +00:00
Christopher Chedeau
5a3303ac5e fix bug with negative margin inside of a justifyContent: center container 2014-12-11 14:12:12 +00:00
Christopher Chedeau
ef73ebd935 add tests for flexWrap 2014-12-11 13:57:03 +00:00
Christopher Chedeau
e0bcbdcfc1 more tweaks to the pretty print function 2014-12-11 13:56:29 +00:00
Christopher Chedeau
0f9b777623 better way to ignore iframe width 2014-12-11 13:44:03 +00:00
Christopher Chedeau
fde2328ba6 better pretty-print function 2014-12-11 13:30:46 +00:00
Christopher Chedeau
8031cbe134 do not infinite loop on random layouts anymore 2014-12-11 12:17:40 +00:00
Felix Oghină
5ab64a699f Add jsr305, couple of @Nullable annotations 2014-12-05 14:59:25 +00:00
Krzysztof Magiera
fbd14263f9 Move isUndefined check to CSSConstants in java code 2014-12-02 22:30:44 +00:00
Krzysztof Magiera
e5ef35e6ff Minor fixes in improvements in Java code. 2014-12-02 18:52:57 +00:00
Felix Oghină
8903bb15c6 Add support for paddingVertical, paddingHorizontal, borderVertical, borderHorizontal
* implement padding & border as arrays of values
* apply padding & border with the correct priority (e.g. left, horizontal, all)
* update transpiler & tests
2014-11-20 17:59:40 +00:00
Felix Oghină
6ee0c5817c Add support for marginVertical and marginHorizontal
* implement margin as an array of values
* apply margins with the correct priority (e.g. left, horizontal, all)
* update transpiler & tests
2014-11-20 17:28:54 +00:00
Christopher Chedeau
c2aa92cd0b Add licenses and remove third party libraries 2014-10-29 08:01:22 -07:00
Andy Street
3d91ccf7ad Addressing comments on code review: Updates markLayoutApplied->markLayoutSeen and makes sure whenever we dirty if and only if we update a value. 2014-10-08 15:42:51 -07:00
Christopher Chedeau
c0f895c6f2 Make align-items: stretch the default 2014-10-08 09:35:44 -07:00
Andy Street
6d93c20610 Java 2014-10-07 16:22:27 -07:00
Andrew Rasmussen
7eef01f299 make setting bottom/right calculate top/left 2014-09-30 15:24:42 -07:00
Andrew Rasmussen
91786cd2c7 make isUndefined public, add CSS_POSITION_COUNT back 2014-09-30 13:18:03 -07:00
Andrew Rasmussen
0ae8bcf8f6 Add second position: absolute pass 2014-09-30 13:11:32 -07:00
Andrew Rasmussen
c149d3110d rename position: absolute test case 2014-09-29 14:07:47 -07:00
Christopher Chedeau
c226656e8f Merge pull request #11 from frantic/keep-consts-in-sync
Add test that makes sure text consts are in sync
2014-09-27 07:19:19 -07:00
Alex Kotliarskyi
308d0edc0b Add test that makes sure text consts are in sync 2014-09-26 20:38:34 -07:00
Alex Kotliarskyi
ba4cf35804 Return bad error code when tests fail 2014-09-26 20:08:37 -07:00
Alex Kotliarskyi
08095b7d2c Travis CI integration 2014-09-26 18:54:34 -07:00