DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

fillNodes should be an optional step #107

New Issue
Closed
opened 2015-08-12 00:58:11 -07:00 by ColinEberhardt · 2 comments
ColinEberhardt commented 2015-08-12 00:58:11 -07:00 (Migrated from github.com)
Copy Link

The current public JS API adapts computeLayout to add a fillNodes step, which tramples over any existing layout properties, see #62

I think the public API should make this optional ...

computeLayout(..., false); // fillNodes turned off

Currently within d3fc we do not use the adapted version of the API.

The current public JS API adapts `computeLayout` to add a fillNodes step, which tramples over any existing `layout` properties, see #62 I think the public API should make this optional ... ``` computeLayout(..., false); // fillNodes turned off ``` Currently within d3fc we do not use the adapted version of the API.
vjeux commented 2015-08-12 10:49:03 -07:00 (Migrated from github.com)
Copy Link

I don't like boolean arguments. Can you just make fillNodes exist only in the test environment and not expose it outside?

I don't like boolean arguments. Can you just make fillNodes exist only in the test environment and not expose it outside?
ColinEberhardt commented 2015-08-12 12:10:59 -07:00 (Migrated from github.com)
Copy Link

Hmm ... you're right, thinking about it boolean args lack discoverability and don't self document.

I'll have a rethink.

Hmm ... you're right, thinking about it boolean args lack discoverability and don't self document. I'll have a rethink.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#107
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?