Web Inconsistency: Node has wrong height #633

New Issue

2017-09-19T01:05:05-07:00

rigdern commented

2017-09-19 01:05:05 -07:00

(Migrated from github.com)

I came across this inconsistency when my team was upgrading its app to a newer version of React Native. This bug was introduced by commit 8eca67e257.

Yoga test case:

<div id="repro" style="height: 500px; width: 500px">
  <div style="align-items: flex-start;">
    <div style="flex-grow: 1; flex-shrink: 1;">
      <div style="flex-grow: 1; flex-shrink: 1;"></div>
    </div>
  </div>
</div>

Result:

FAILURE YogaTest repro
      Expected: 0
To be equal to: YGNodeLayoutGetHeight(root_child0)
      Which is: 500

I came across this inconsistency when my team was upgrading its app to a newer version of React Native. This bug was introduced by commit 8eca67e2572183138c2e0e501896a34a5f72d434. **Yoga test case:** ``` <div id="repro" style="height: 500px; width: 500px"> <div style="align-items: flex-start;"> <div style="flex-grow: 1; flex-shrink: 1;"> <div style="flex-grow: 1; flex-shrink: 1;"></div> </div> </div> </div> ```  **Result:** ``` FAILURE YogaTest repro Expected: 0 To be equal to: YGNodeLayoutGetHeight(root_child0) Which is: 500 ```

rigdern commented

2017-10-03 21:31:49 -07:00

(Migrated from github.com)

@emilsjolander Can you reopen this? I believe @woehrl01's fix was reverted and he has an alternative fix under review (#635).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#633