DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix shrinking in non strech alignments while retaining legacy behaviour #635

Closed
woehrl01 wants to merge 1 commits from flex_start_shrink into master
pull from: flex_start_shrink
merge into: DaddyFrosty:master
Conversation 2 Commits 1 Files Changed 7 +903 -1
woehrl01 commented 2017-09-21 10:56:21 -07:00 (Migrated from github.com)
Copy Link

This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for useLegacyStretchBehaviour

Fixes #633

This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour``` Fixes #633
emilsjolander commented 2017-11-24 06:27:51 -08:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
facebook-github-bot (Migrated from github.com) reviewed 2017-11-24 06:28:04 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D6408037).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#635
No description provided.
Delete Branch "flex_start_shrink"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?