DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Expose dirtied func in Javascript bindings #842

Closed
rmhartog wants to merge 3 commits from js-dirtied-func into master
pull from: js-dirtied-func
merge into: DaddyFrosty:master
Conversation 7 Commits 3 Files Changed 4 +712 -481
rmhartog commented 2018-12-31 04:24:56 -08:00 (Migrated from github.com)
Copy Link

Yoga currently has the concept of a 'dirtied func', which is called when a Node becomes dirty, which can be useful to trigger a repaint. This PR exposes that functionality in the Javascript bindings.

Yoga currently has the concept of a 'dirtied func', which is called when a Node becomes dirty, which can be useful to trigger a repaint. This PR exposes that functionality in the Javascript bindings.
rmhartog commented 2019-01-15 05:14:17 -08:00 (Migrated from github.com)
Copy Link

Hello @davidaurelio I see that you've been actively working on some things in this project, do you think you could have a look at this? CI is failing, but that's unrelated (fixed in #843). Let me know if it's not okay to tag you like this and if there is a better way to get some eyes on these PRs 😄

Hello @davidaurelio I see that you've been actively working on some things in this project, do you think you could have a look at this? CI is failing, but that's unrelated (fixed in #843). Let me know if it's not okay to tag you like this and if there is a better way to get some eyes on these PRs 😄
davidaurelio commented 2019-01-28 12:43:00 -08:00 (Migrated from github.com)
Copy Link

ok, let’s merge it. Which way did you test this?

ok, let’s merge it. Which way did you test this?
facebook-github-bot (Migrated from github.com) reviewed 2019-01-28 12:44:14 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D13847093).
rmhartog commented 2019-01-29 01:33:56 -08:00 (Migrated from github.com)
Copy Link

I ported the YGDirtiedTest to JavaScript, but had not included in the PR for some reason, my apologies. It replicates the bahaviour of the YGDirtiedTest.cpp.

I ported the `YGDirtiedTest` to JavaScript, but had not included in the PR for some reason, my apologies. It replicates the bahaviour of the `YGDirtiedTest.cpp`.
facebook-github-bot (Migrated from github.com) reviewed 2019-01-29 02:34:09 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D13847093).
rmhartog commented 2019-01-29 04:07:00 -08:00 (Migrated from github.com)
Copy Link

Noticed that the m_dirtiedFunc should also be cleaned up when the node is reset, same as the measure function, added those changes to the branch.

Noticed that the `m_dirtiedFunc` should also be cleaned up when the node is reset, same as the measure function, added those changes to the branch.
facebook-github-bot (Migrated from github.com) reviewed 2019-01-29 12:27:21 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D13847093).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#842
No description provided.
Delete Branch "js-dirtied-func"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?