Add fb_native_wrapper.bzl to fix Travis CI #843

2018-12-31T04:48:02-08:00

rmhartog commented

2018-12-31 04:48:02 -08:00

(Migrated from github.com)

When I was implementing #842, I noticed that CI was failing, but it did not seem to be caused by my changes. As you can see in the build log (https://travis-ci.org/facebook/yoga/jobs/473825507#L1217), the build depends on a build script that is not in the repository. In d02f4a94de, @scottrice changed the build scripts to depend on fb_native_wrapper.bzl without introducing that file into the repository.

In this PR, I've introduced the bzl file, copied from the react-native project. Since it appears to only be a wrapper at this point, I'm assuming that this is the correct approach.

When I was implementing #842, I noticed that CI was failing, but it did not seem to be caused by my changes. As you can see in the build log (https://travis-ci.org/facebook/yoga/jobs/473825507#L1217), the build depends on a build script that is not in the repository. In d02f4a94de589d91dc719e51ff6c8c5b302df184, @scottrice changed the build scripts to depend on `fb_native_wrapper.bzl` without introducing that file into the repository. In this PR, I've introduced the bzl file, copied from the react-native project. Since it appears to only be a wrapper at this point, I'm assuming that this is the correct approach.

davidaurelio commented

2019-01-28 13:40:44 -08:00

(Migrated from github.com)

Thank you so much! Trying this out right now.

facebook-github-bot (Migrated from github.com) reviewed 2019-01-28 13:41:17 -08:00

facebook-github-bot (Migrated from github.com) left a comment

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D13848880).

facebook-github-bot (Migrated from github.com) reviewed 2019-01-29 03:07:45 -08:00

facebook-github-bot (Migrated from github.com) left a comment

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D13848880).

facebook-github-bot (Migrated from github.com) reviewed 2019-01-29 03:42:44 -08:00

facebook-github-bot (Migrated from github.com) left a comment

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D13859598).

davidaurelio commented

2019-01-29 07:48:51 -08:00

(Migrated from github.com)

we have some internal hiccups around this file – I will have to do some work, but we will merge it.

rmhartog commented

2019-01-29 09:03:36 -08:00

(Migrated from github.com)

Thanks for the feedback, let me know if there is anything I can do to help you :)

👍 1

davidaurelio commented

2019-01-29 13:20:06 -08:00

(Migrated from github.com)

Thank you!. Nothing you can do – shipit was configured a bit too strictly. I am waiting for a re-deploy now, and then we should be able to get this one in.

Thank you!. Nothing you can do – [shipit](https://github.com/facebook/fbshipit) was configured a bit too strictly. I am waiting for a re-deploy now, and then we should be able to get this one in.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#843