DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix absolute position when padding on parent in place #1016

Open
woehrl01 wants to merge 2 commits from woehrl01/fix-absolute-with-padding into main
pull from: woehrl01/fix-absolute-with-padding
merge into: DaddyFrosty:main
Conversation 0 Commits 2 Files Changed 3 +56 -19
woehrl01 commented 2020-06-11 08:50:46 -07:00 (Migrated from github.com)
Copy Link

This PR fixes #850 where the padding of the parent is used mistakenly included for the calculation of children's size.

It also fixes the bug where the boarder of the parent is used, instead of the padding for positioning.

This PR fixes #850 where the padding of the parent is used mistakenly included for the calculation of children's size. It also fixes the bug where the boarder of the parent is used, instead of the padding for positioning.
This pull request has changes conflicting with the target branch.
  • gentest/fixtures/YGAbsolutePositionTest.html
  • tests/YGAbsolutePositionTest.cpp
  • yoga/Yoga.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin woehrl01/fix-absolute-with-padding:woehrl01/fix-absolute-with-padding
git checkout woehrl01/fix-absolute-with-padding
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Algorithm
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1016
No description provided.
Delete Branch "woehrl01/fix-absolute-with-padding"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?