DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix env setting and Android setup #1085

Closed
passy wants to merge 1 commits from github-actions-fix into master
pull from: github-actions-fix
merge into: DaddyFrosty:master
Conversation 2 Commits 1 Files Changed 1 +1 -6
passy commented 2021-05-21 05:11:05 -07:00 (Migrated from github.com)
Copy Link

Summary:
The current way env variables are set is no longer supported. The manual Android setup is also quite tricky to maintain and can mostly be done through GitHub Actions itself.

Please note that the actual build is still failing but that's because we're so far behind with the setup here that the Gradle version no longer works on a modern JVM. I'll fix that in subsequent diffs.

Test Plan:
CI

Summary: The current way env variables are set is no longer supported. The manual Android setup is also quite tricky to maintain and can mostly be done through GitHub Actions itself. Please note that the actual build is still failing but that's because we're so far behind with the setup here that the Gradle version no longer works on a modern JVM. I'll fix that in subsequent diffs. Test Plan: CI
facebook-github-bot commented 2021-05-21 05:28:29 -07:00 (Migrated from github.com)
Copy Link

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D28602084).
facebook-github-bot commented 2021-05-21 10:11:49 -07:00 (Migrated from github.com)
Copy Link

@passy merged this pull request in facebook/yoga@508f4eacdf.

@passy merged this pull request in facebook/yoga@508f4eacdf430cec8f163884c6c107dd80ec4712.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1085
No description provided.
Delete Branch "github-actions-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?