DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

[yoga] Replace float with double #1095

Closed
cntrump wants to merge 1 commits from pr_replace_float_with_double into main
pull from: pr_replace_float_with_double
merge into: DaddyFrosty:main
Conversation 1 Commits 1 Files Changed 36 +694 -686
cntrump commented 2021-07-04 06:35:51 -07:00 (Migrated from github.com)
Copy Link
No description provided.
NickGerleman (Migrated from github.com) requested changes 2022-10-03 08:44:04 -07:00
NickGerleman (Migrated from github.com) left a comment
Copy Link

Thanks for the contribution!

I don't think this change could be accepted in its current form, since it would break the existing API of Yoga. If there are cases where we discovered that we do need this extra precision, it might make sense to hide this behind a separate configurable type.

I think it would also be wise to perform some performance/memory analysis, to see if that extra precision comes at a cost.

Thanks for the contribution! I don't think this change could be accepted in its current form, since it would break the existing API of Yoga. If there are cases where we discovered that we do need this extra precision, it might make sense to hide this behind a separate configurable type. I think it would also be wise to perform some performance/memory analysis, to see if that extra precision comes at a cost.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
NickGerleman
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Algorithm
C++ Enhancement
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1095
No description provided.
Delete Branch "pr_replace_float_with_double"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?