Add test that makes sure text consts are in sync #11

2014-09-26T20:42:09-07:00

frantic commented

2014-09-26 20:42:09 -07:00

(Migrated from github.com)

RFC. This makes sure we are always in sync with the browser consts if we run tests in browser.

However I think we should use text measurements only for random tests generator and update consts when they change.

RFC. This makes sure we are always in sync with the browser consts if we run tests in browser. However I think we should use text measurements only for random tests generator and update consts when they change.

vjeux commented

2014-09-26 21:10:07 -07:00

(Migrated from github.com)

The normal tests are doing layout, expected and browser. This is super important in my mind to do the third one as it ensures that we're not inventing an alternate reality where we write tests that pass against the expected version but not the browser.

I strongly believe that it's worth the pain of managing font sizes in order to get this propert

The normal tests are doing layout, expected and browser. This is super important in my mind to do the third one as it ensures that we're not inventing an alternate reality where we write tests that pass against the expected version but not the browser. I strongly believe that it's worth the pain of managing font sizes in order to get this propert

vjeux commented

2014-09-26 21:14:13 -07:00

(Migrated from github.com)

Want to land this one? It looks good and travis is happy :P

frantic commented

2014-09-26 21:43:31 -07:00

(Migrated from github.com)

Travis is happy, but it doesn't run browser tests, and this one is browser-only

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#11