【YogaKit】Fix two crashes. YogaKitSample upgrade to swift 5 #1144

2022-04-28T19:11:58-07:00

Henrs commented

2022-04-28 19:11:58 -07:00

(Migrated from github.com)

if A view addSubviews(B), B view addSubviews(C), sometimes we need A view addSubviews(C), yoga asset because of C had a owner, when node insert a child node, i think we need to remove child node from owner first.
yoga maybe calculate a Nan value, but UIKit size can't accept a Nan Value, it will be cause unexpect crashes
YogaKitSample upgrade to swift 5

1. if A view addSubviews(B), B view addSubviews(C), sometimes we need A view addSubviews(C), yoga asset because of C had a owner, when node insert a child node, i think we need to remove child node from owner first. 2. yoga maybe calculate a Nan value, but UIKit size can't accept a Nan Value, it will be cause unexpect crashes 3. YogaKitSample upgrade to swift 5

facebook-github-bot commented

2022-04-28 19:12:02 -07:00

(Migrated from github.com)

Hi @Henrs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Hi @Henrs! Thank you for your pull request and welcome to our community. # Action Required In order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you. # Process In order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%231144). Thanks!

facebook-github-bot commented

2022-04-28 21:32:22 -07:00

(Migrated from github.com)

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NickGerleman commented

2023-06-13 08:02:17 -07:00

(Migrated from github.com)

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.

Henrs commented

2023-07-12 20:39:23 -07:00

(Migrated from github.com)

r

ok，Does version 2.0.0 mean that YogaKit is the final version？

> r ok，Does version 2.0.0 mean that YogaKit is the final version？

NickGerleman commented

2023-07-13 20:56:43 -07:00

(Migrated from github.com)

Yes, 2.0 is the final version of YogaKit by Meta.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1144