DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Stale flex basis value used with cached values #1161

Open
rozele wants to merge 4 commits from rozele/export-D39929963 into main
pull from: rozele/export-D39929963
merge into: DaddyFrosty:main
Conversation 2 Commits 4 Files Changed 1 +91
rozele commented 2022-09-29 09:15:58 -07:00 (Migrated from github.com)
Copy Link

Summary:
We're occasionally seeing text truncation occur on Windows. It appears to occur when a cached main axis value is supplied to the flex basis computation for children, resulting in a stale flex basis value getting used.

This diff just contributes a unit test that reliably reproduces this case.

Differential Revision: D39929963

Summary: We're occasionally seeing text truncation occur on Windows. It appears to occur when a cached main axis value is supplied to the flex basis computation for children, resulting in a stale flex basis value getting used. This diff just contributes a unit test that reliably reproduces this case. Differential Revision: D39929963
facebook-github-bot commented 2022-09-29 09:16:47 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D39929963

This pull request was **exported** from Phabricator. Differential Revision: [D39929963](https://www.internalfb.com/diff/D39929963)
jeetiss commented 2023-03-06 01:12:24 -08:00 (Migrated from github.com)
Copy Link

I've experienced the same problem with react-pdf and satori

Here is the code sandbox with javascript reproduction

I've experienced the same problem with `react-pdf` and `satori` - https://github.com/vercel/satori/issues/393 - https://github.com/diegomura/react-pdf/issues/2182 Here is the [code sandbox](https://codesandbox.io/s/yoga-setmeasurefunc-misuse-v168ep) with `javascript` reproduction
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin rozele/export-D39929963:rozele/export-D39929963
git checkout rozele/export-D39929963
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Algorithm
CLA Signed
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1161
No description provided.
Delete Branch "rozele/export-D39929963"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?