DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

WIP: Update Yoga.cpp #1189

Closed
jacobp100 wants to merge 4 commits from patch-1 into main
pull from: patch-1
merge into: DaddyFrosty:main
Conversation 9 Commits 4 Files Changed 1 +6 -2
jacobp100 commented 2022-12-09 07:21:45 -08:00 (Migrated from github.com)
Copy Link

Just to see test results on CI

Just to see test results on CI
jacobp100 commented 2022-12-09 07:31:38 -08:00 (Migrated from github.com)
Copy Link

@cortinico are you able to give me approval to run the workflows?

@cortinico are you able to give me approval to run the workflows?
NickGerleman commented 2022-12-11 20:50:46 -08:00 (Migrated from github.com)
Copy Link

@cortinico are you able to give me approval to run the workflows?

I started this off. But the CI run in OSS doesn’t run the unit tests. I’m going to prioritize finally getting the GTest UTs running in OSS again before I take holiday off after the end of this week.

> @cortinico are you able to give me approval to run the workflows? I started this off. But the CI run in OSS doesn’t run the unit tests. I’m going to prioritize finally getting the GTest UTs running in OSS again before I take holiday off after the end of this week.
❤️ 1
NickGerleman commented 2022-12-13 06:36:34 -08:00 (Migrated from github.com)
Copy Link

I will pull this so I can report UT results.

I will pull this so I can report UT results.
facebook-github-bot commented 2022-12-13 06:37:24 -08:00 (Migrated from github.com)
Copy Link

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D41998392).
NickGerleman commented 2022-12-13 07:30:09 -08:00 (Migrated from github.com)
Copy Link

It looks like this change is passing all UTs 👍

It looks like this change is passing all UTs 👍
❤️ 2
NickGerleman commented 2022-12-28 02:39:02 -08:00 (Migrated from github.com)
Copy Link

It's... not the properly debuggable C++ build just yet, but FYI @jacobp100 @intergalacticspacehighway that tests generated from the fixtures should now be run in the "JavaScript / Test" workflows. Still working to get the rest of the suite enabled and a better local experience.

It's... not the properly debuggable C++ build just yet, but FYI @jacobp100 @intergalacticspacehighway that tests generated from the fixtures should now be run in the "JavaScript / Test" workflows. Still working to get the rest of the suite enabled and a better local experience.
NickGerleman commented 2022-12-28 02:43:15 -08:00 (Migrated from github.com)
Copy Link

The test failure being shown now is because the automatically merged output with this change and main has both your fix, and the one from @intergalacticspacehighway, doing the same thing I think.

The test failure being shown now is because the automatically merged output with this change and main has both your fix, and the one from @intergalacticspacehighway, doing the same thing I think.
NickGerleman commented 2023-01-16 08:00:23 -08:00 (Migrated from github.com)
Copy Link

C++ UTs are now running in OSS 👍

Should be relatively easy to run and debug locally now too as well.

C++ UTs are now running in OSS 👍 Should be relatively easy to run and debug locally now too as well.
❤️ 1
NickGerleman commented 2023-09-13 18:54:57 -07:00 (Migrated from github.com)
Copy Link

Got around to removing the gap-specific hack in https://github.com/facebook/yoga/pull/1380

Note that we do want to do this at the point of the last element, instead of the first, since we use betweenMainDim for positioning, and will otherwise incorrectly position the child after the first.

Got around to removing the gap-specific hack in https://github.com/facebook/yoga/pull/1380 Note that we do want to do this at the point of the last element, instead of the first, since we use `betweenMainDim` for positioning, and will otherwise incorrectly position the child after the first.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1189
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?