DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Undeprecate Config setting APIs (#36990) #1251

Closed
NickGerleman wants to merge 1 commits from export-D45133646 into main
pull from: export-D45133646
merge into: DaddyFrosty:main
Conversation 2 Commits 1 Files Changed 4 +13 -14
NickGerleman commented 2023-04-19 17:02:25 -07:00 (Migrated from github.com)
Copy Link

Summary:
X-link: https://github.com/facebook/react-native/pull/36990

YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node.

While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this.

This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it.

Differential Revision: D45133646

Summary: X-link: https://github.com/facebook/react-native/pull/36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Differential Revision: D45133646
facebook-github-bot commented 2023-04-19 17:03:09 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45133646

This pull request was **exported** from Phabricator. Differential Revision: [D45133646](https://www.internalfb.com/diff/D45133646)
facebook-github-bot commented 2023-04-20 14:06:01 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@19e15a4455.

This pull request has been merged in facebook/yoga@19e15a4455a33cbad7b053f020e3fd47aa89359c.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1251
No description provided.
Delete Branch "export-D45133646"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?