DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

C++ style enums 7/N: MeasureMode #1389

Closed
NickGerleman wants to merge 7 commits from export-D49271165 into main
pull from: export-D49271165
merge into: DaddyFrosty:main
Conversation 5 Commits 7 Files Changed 39 +1178 -273

7 Commits

Author SHA1 Message Date
Nick Gerleman
22bee6e9d6 C++ style enums 7/N: MeasureMode (#1389) 
Summary:
X-link: https://github.com/facebook/react-native/pull/39452

Pull Request resolved: https://github.com/facebook/yoga/pull/1389

This converts usages of YGMeasureMode to MeasureMode

Reviewed By: rozele

Differential Revision: D49271165

fbshipit-source-id: a6ab7509a3f74bc6e1c42c0ce3376e1e7447f4dd
 2023-09-14 20:50:26 -07:00
Nick Gerleman
c4d0b6ae7c C++ style enums 6/N: PrintOptions 
Summary: This converts usages of YGPrintOptions to PrintOptions

Differential Revision: D49270929

fbshipit-source-id: 10c8dd6e711581a62f234658016afe697e2e44ce
 2023-09-14 20:50:01 -07:00
Nick Gerleman
9a73336ba3 C++ style enums 5/N: LogLevel 
Summary: This converts usages of YGLogLevel to LogLevel

Differential Revision: D49270695

fbshipit-source-id: 13ce04476546b69f222e38885f12597e0e8cdae9
 2023-09-14 20:50:01 -07:00
Nick Gerleman
477e5dc286 C++ style enums 4/N: Errata 
Summary: This converts usages of YGErrata to Errata

Differential Revision: D49270354

fbshipit-source-id: 70e61b04543a2431766dfe1e51b0731e8e753188
 2023-09-14 20:50:01 -07:00
Nick Gerleman
e85cb99267 C++ style enums 3/N: ExperimentalFeature 
Differential Revision: D49269440

fbshipit-source-id: 17582f27ed995f861deeed6bcb0c0a00d12da47e
 2023-09-14 20:50:01 -07:00
Nick Gerleman
f8331b5a48 C++ style enums 2/N: NodeType 
Differential Revision: D49269117

fbshipit-source-id: 0a1dd2c4359c4871b01b21e61d636fbc7f239f2a
 2023-09-14 20:50:01 -07:00
Nick Gerleman
1f4c524b0e C++ style enums 1/N: Generator 
Summary:
This adds logic to the enum generator to generate C++ style scoped enums.

This gives us a few nicities over C enums, even if both must exist:
1. We can add types and keep unsgined enums directly in bitfields
2. Style/readability
3. Avoiding implicit int conversion

Differential Revision: D49267996

fbshipit-source-id: 0ba9a79e19616f55abdc15012fbfd26933c6d179
 2023-09-14 20:50:01 -07:00