DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Added document how to build Yoga for Java #1728

Open
darekbx wants to merge 1 commits from darekbx/add_info_how_build_yoga_for_java into main
pull from: darekbx/add_info_how_build_yoga_for_java
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 1 +99
darekbx commented 2024-10-16 02:40:49 -07:00 (Migrated from github.com)
Copy Link

Added documentation detailing how to build the Yoga library for Java/Android.

Added documentation detailing how to build the Yoga library for Java/Android.
vercel[bot] commented 2024-10-16 02:40:53 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:43am
[vc]: #cAYBYlVwZOHOUYOzN46LNxYV0GotMtfELaxaVIxDh3I=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzRjVm9kaFA5YzZCUTlqOVN1Y1RURTJiVUd4TUQiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLWRhcmVrYngtYWRkaW5mb2hvd2J1aS0zOGU5YzItZmJvcGVuc291cmNlLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLWRhcmVrYngtYWRkaW5mb2hvd2J1aS0zOGU5YzItZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifX1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/4cVodhP9c6BQ9j9SucTTE2bUGxMD)) | [Visit Preview](https://vercel.live/open-feedback/yoga-website-git-fork-darekbx-addinfohowbui-38e9c2-fbopensource.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-darekbx-addinfohowbui-38e9c2-fbopensource.vercel.app?via=pr-comment-feedback-link) | Oct 16, 2024 9:43am |
NickGerleman commented 2024-10-16 04:01:12 -07:00 (Migrated from github.com)
Copy Link

Writing instructions for how to patch the current build logic to build JNI part of library for macOS doesn’t seem very durable.

For Android we rely on Android Gradle Plugin’s NDK/CMake integration, and just distribute binaries.

If we wanted to support building Java locally more gracefully, we probably want a way to have Gradle without Android bits hook CMake, or potentially just go the route of Gradle C++ libraries more venally. https://docs.gradle.org/current/userguide/cpp_library_plugin.html

Separately, out of curiosity, what warnings as errors did you run into? We have a good number of different builds with high warning level in OSS CI, and internally at Meta, so I’m curious what gap we still have.

Writing instructions for how to patch the current build logic to build JNI part of library for macOS doesn’t seem very durable. For Android we rely on Android Gradle Plugin’s NDK/CMake integration, and just distribute binaries. If we wanted to support building Java locally more gracefully, we probably want a way to have Gradle without Android bits hook CMake, or potentially just go the route of Gradle C++ libraries more venally. https://docs.gradle.org/current/userguide/cpp_library_plugin.html Separately, out of curiosity, what warnings as errors did you run into? We have a good number of different builds with high warning level in OSS CI, and internally at Meta, so I’m curious what gap we still have.
lunaleaps commented 2024-10-16 14:01:31 -07:00 (Migrated from github.com)
Copy Link

Can't speak on the actual build instructions, but wondering why the README wasn't used for these instructions.

Can't speak on the actual build instructions, but wondering why the README wasn't used for these instructions.
darekbx commented 2024-10-18 00:16:30 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman We got some errors and warnings while building Yoga for Java on MacOs with Apple CPU. We are creating custom implementation of Flexbox layout for Android Compose.

@NickGerleman We got some errors and warnings while building Yoga for Java on MacOs with Apple CPU. We are creating custom implementation of Flexbox layout for Android Compose.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin darekbx/add_info_how_build_yoga_for_java:darekbx/add_info_how_build_yoga_for_java
git checkout darekbx/add_info_how_build_yoga_for_java
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Shared with Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1728
No description provided.
Delete Branch "darekbx/add_info_how_build_yoga_for_java"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?