DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Surround some intrinsic sizing tests in non-relative container #1748

Open
joevilches wants to merge 1 commits from joevilches/export-D66275587 into main
pull from: joevilches/export-D66275587
merge into: DaddyFrosty:main
Conversation 3 Commits 1 Files Changed 4 +2725 -2015
joevilches commented 2024-11-20 17:39:47 -08:00 (Migrated from github.com)
Copy Link

Summary: Some of these were specified as relative but that makes the top value of layout incorrect. Surrounding in a div which is absolute so they all layout in the top left.

Differential Revision: D66275587

Summary: Some of these were specified as relative but that makes the `top` value of layout incorrect. Surrounding in a div which is absolute so they all layout in the top left. Differential Revision: D66275587
vercel[bot] commented 2024-11-20 17:39:51 -08:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 1:45am
[vc]: #40hCCw4mT5SLFF9baqgNd9b/3Q3ukDKSn29dJMuXETE=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzdVNUFKVGdyY1hycHRWcDZENzVqWUxnY2FiUjQiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLWpvZXZpbGNoZXMtZXhwb3J0LWQ2NjI3NTU4Ny1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ5b2dhLXdlYnNpdGUtZ2l0LWZvcmstam9ldmlsY2hlcy1leHBvcnQtZDY2Mjc1NTg3LWZib3BlbnNvdXJjZS52ZXJjZWwuYXBwIn19XX0= **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/7U5AJTgrcXrptVp6D75jYLgcabR4)) | [Visit Preview](https://vercel.live/open-feedback/yoga-website-git-fork-joevilches-export-d66275587-fbopensource.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-joevilches-export-d66275587-fbopensource.vercel.app?via=pr-comment-feedback-link) | Nov 21, 2024 1:45am |
facebook-github-bot commented 2024-11-20 17:41:46 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D66275587

This pull request was **exported** from Phabricator. Differential Revision: [D66275587](https://www.internalfb.com/diff/D66275587)
facebook-github-bot commented 2024-11-20 17:43:17 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D66275587

This pull request was **exported** from Phabricator. Differential Revision: [D66275587](https://www.internalfb.com/diff/D66275587)
This pull request has changes conflicting with the target branch.
  • gentest/fixtures/YGIntrinsicSizeTest.html
  • java/tests/generated/com/facebook/yoga/YGIntrinsicSizeTest.java
  • javascript/tests/generated/YGIntrinsicSizeTest.test.ts
  • tests/generated/YGIntrinsicSizeTest.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin joevilches/export-D66275587:joevilches/export-D66275587
git checkout joevilches/export-D66275587
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1748
No description provided.
Delete Branch "joevilches/export-D66275587"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?