DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Migrate YogaNode to Kotlin #1843

Open
mateoguzmana wants to merge 1 commits from mateoguzmana/feat/yoga-node into main
pull from: mateoguzmana/feat/yoga-node
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 2 +273 -279
mateoguzmana commented 2025-08-07 15:38:15 -07:00 (Migrated from github.com)
Copy Link

Migrate com.facebook.yoga.YogaNode to Kotlin.

Test plan:

RN

yarn android
yarn test-android

Yoga

./gradlew :yoga:assembleDebug
Migrate com.facebook.yoga.YogaNode to Kotlin. **Test plan:** RN ```sh yarn android yarn test-android ``` Yoga ```sh ./gradlew :yoga:assembleDebug ```
vercel[bot] commented 2025-08-07 15:38:19 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 10:41pm
[vc]: #t3c0/Crp8kXBb8O3pVxZF56Kqke4FTL0FSiWt/CHsjE=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzM2dzZBQ1BBanNWR0tLcVk0NWRpV0hrNXJqMnQiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW1hdGVvZ3V6bWFuYS1mZWF0LXlvZ2Etbm9kZS1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ5b2dhLXdlYnNpdGUtZ2l0LWZvcmstbWF0ZW9ndXptYW5hLWZlYXQteW9nYS1ub2RlLWZib3BlbnNvdXJjZS52ZXJjZWwuYXBwIn19XX0= **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/36w6ACPAjsVGKKqY45diWHk5rj2t)) | [Visit Preview](https://yoga-website-git-fork-mateoguzmana-feat-yoga-node-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-mateoguzmana-feat-yoga-node-fbopensource.vercel.app?via=pr-comment-feedback-link) | Aug 7, 2025 10:41pm |
facebook-github-bot commented 2025-08-08 09:20:03 -07:00 (Migrated from github.com)
Copy Link

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79897715.

@cortinico has imported this pull request. If you are a Meta employee, you can view this in [D79897715](https://www.internalfb.com/diff/D79897715?dst_version_fbid=1482888169561005).
facebook-github-bot commented 2025-08-11 09:51:23 -07:00 (Migrated from github.com)
Copy Link

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79897715.

@cortinico has imported this pull request. If you are a Meta employee, you can view this in [D79897715](https://www.internalfb.com/diff/D79897715?dst_version_fbid=2230578834071932).
cortinico commented 2025-08-12 03:46:40 -07:00 (Migrated from github.com)
Copy Link

This has the same problem as https://github.com/facebook/yoga/pull/1844#issuecomment-3178775482

This has the same problem as https://github.com/facebook/yoga/pull/1844#issuecomment-3178775482
👍 1
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mateoguzmana/feat/yoga-node:mateoguzmana/feat/yoga-node
git checkout mateoguzmana/feat/yoga-node
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Shared with Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1843
No description provided.
Delete Branch "mateoguzmana/feat/yoga-node"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?