DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Feature hidden nodes #302

Closed
roxlu wants to merge 8 commits from feature-hidden-nodes into master
pull from: feature-hidden-nodes
merge into: DaddyFrosty:master
Conversation 16 Commits 8 Files Changed 2 +447 -1569
roxlu commented 2016-12-23 14:41:35 -08:00 (Migrated from github.com)
Copy Link
No description provided.
facebook-github-bot commented 2016-12-23 14:41:43 -08:00 (Migrated from github.com)
Copy Link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! **If you are contributing on behalf of someone else (eg your employer)**: the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.
emilsjolander commented 2016-12-24 03:53:00 -08:00 (Migrated from github.com)
Copy Link

I like the suggestion @woehrl01 had in #241 about using the display property from css. So add an enums with values none and flex. What do you think?

I like the suggestion @woehrl01 had in #241 about using the `display` property from css. So add an enums with values `none` and `flex`. What do you think?
emilsjolander commented 2017-01-05 12:02:34 -08:00 (Migrated from github.com)
Copy Link

@roxlu Are you planning to update this?

@roxlu Are you planning to update this?
roxlu commented 2017-01-05 12:28:43 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander Yes, I'll fix that this weekend. Sorry for not replying earlier.

@emilsjolander Yes, I'll fix that this weekend. Sorry for not replying earlier.
emilsjolander commented 2017-01-05 12:29:25 -08:00 (Migrated from github.com)
Copy Link

Np! Just checking in :) no rush
On Thu, 5 Jan 2017 at 20:28, @roxlu notifications@github.com wrote:

@emilsjolander https://github.com/emilsjolander Yes, I'll fix that this
weekend. Sorry for not replying earlier.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/yoga/pull/302#issuecomment-270748581, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdIpDUEjx2fzKhL5dALuGITHuIUuekYks5rPVJ9gaJpZM4LVGNi
.

Np! Just checking in :) no rush On Thu, 5 Jan 2017 at 20:28, @roxlu <notifications@github.com> wrote: > @emilsjolander <https://github.com/emilsjolander> Yes, I'll fix that this > weekend. Sorry for not replying earlier. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/facebook/yoga/pull/302#issuecomment-270748581>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ABdIpDUEjx2fzKhL5dALuGITHuIUuekYks5rPVJ9gaJpZM4LVGNi> > . >
joce commented 2017-01-16 08:52:29 -08:00 (Migrated from github.com)
Copy Link

Hey @roxlu This is a feature we'd definitely need. However, having it as a property is is must for us. Tests are also required.
Do you have any plans to update to a property and to write tests? If not, is this something I could help with?

Hey @roxlu This is a feature we'd definitely need. However, having it as a property is is must for us. Tests are also required. Do you have any plans to update to a property and to write tests? If not, is this something I could help with?
emilsjolander commented 2017-01-18 10:54:30 -08:00 (Migrated from github.com)
Copy Link

@joce Feel free to put up a PR of your own. @roxlu is probably busy with other things and would love someone else to help out 👍

@joce Feel free to put up a PR of your own. @roxlu is probably busy with other things and would love someone else to help out 👍
joce commented 2017-01-18 13:49:53 -08:00 (Migrated from github.com)
Copy Link

Will look at this then!

Will look at this then!
roxlu commented 2017-01-19 00:50:52 -08:00 (Migrated from github.com)
Copy Link

Hey @joce and @emilsjolander I've been ill last week and am catching up on work so I won't have any spare time for this until the end of February. @joce my branch with the hide/show feature is here: https://github.com/roxlu/css-layout/tree/feature-hidden-nodes if you want to have a look.

Hey @joce and @emilsjolander I've been ill last week and am catching up on work so I won't have any spare time for this until the end of February. @joce my branch with the hide/show feature is here: https://github.com/roxlu/css-layout/tree/feature-hidden-nodes if you want to have a look.
joce commented 2017-01-24 12:04:01 -08:00 (Migrated from github.com)
Copy Link

A major issue I have however is that I'm on Windows, compiling with VisualStudio, and therefore I do not have a C99 compiler. I would need to have this feature based on a branch that compiles in C++98. Is this workable for you?

A major issue I have however is that I'm on Windows, compiling with VisualStudio, and therefore I do not have a C99 compiler. I would need to have this feature based on a branch that compiles in C++98. Is this workable for you?
woehrl01 commented 2017-01-24 12:08:03 -08:00 (Migrated from github.com)
Copy Link

@joce I had the same problem. compiling on windows works with vs15 community edition.

@joce I had the same problem. compiling on windows works with vs15 community edition.
joce commented 2017-01-24 12:11:39 -08:00 (Migrated from github.com)
Copy Link

@woehrl01 Excellent! I'll give that a try tonight, then.

@woehrl01 Excellent! I'll give that a try tonight, then.
emilsjolander commented 2017-01-30 09:21:27 -08:00 (Migrated from github.com)
Copy Link

@joce any update?

@joce any update?
joce commented 2017-01-31 10:03:01 -08:00 (Migrated from github.com)
Copy Link

Taken with other fires at work atm.

On Mon, Jan 30, 2017 at 12:21 PM, Emil Sjölander notifications@github.com
wrote:

@joce https://github.com/joce any update?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/yoga/pull/302#issuecomment-276126352, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE56QZtOWxY9q6fPDP_CLf1mx5WOQByks5rXhwcgaJpZM4LVGNi
.

Taken with other fires at work atm. On Mon, Jan 30, 2017 at 12:21 PM, Emil Sjölander <notifications@github.com> wrote: > @joce <https://github.com/joce> any update? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/facebook/yoga/pull/302#issuecomment-276126352>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAE56QZtOWxY9q6fPDP_CLf1mx5WOQByks5rXhwcgaJpZM4LVGNi> > . >
woehrl01 commented 2017-01-31 11:50:35 -08:00 (Migrated from github.com)
Copy Link

@joce @emilsjolander I help out with a new PR #369 with the suggested changes. So you can focus on the fires @joce 🔥 🏃 😄

@joce @emilsjolander I help out with a new PR #369 with the suggested changes. So you can focus on the fires @joce 🔥 🏃 😄
emilsjolander commented 2017-02-02 05:11:14 -08:00 (Migrated from github.com)
Copy Link

closing this as @woehrl01 has opened up #369

closing this as @woehrl01 has opened up #369

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#302
No description provided.
Delete Branch "feature-hidden-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?