DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add YGLayoutGetMargin #335

Closed
arcanis wants to merge 4 commits from get-margin into master
pull from: get-margin
merge into: DaddyFrosty:master
Conversation 10 Commits 4 Files Changed 16 +288 -29
arcanis commented 2017-01-12 01:57:03 -08:00 (Migrated from github.com)
Copy Link

Fix #326. I'll open another PR once this one gets accepted to add support for YGLayoutGetBorder 👌

Fix #326. I'll open another PR once this one gets accepted to add support for `YGLayoutGetBorder` 👌
emilsjolander commented 2017-01-12 02:15:29 -08:00 (Migrated from github.com)
Copy Link

Could you add the c# and java bindings for this as well? Should be fairly straight forward as it will look exactly like the padding ones.

Could you add the c# and java bindings for this as well? Should be fairly straight forward as it will look exactly like the padding ones.
arcanis commented 2017-01-12 02:19:58 -08:00 (Migrated from github.com)
Copy Link

Eh eh, I was working on them, they've just been pushed :) I haven't been able to test them yet, will Travis run the tests for those interfaces as well ?

Eh eh, I was working on them, they've just been pushed :) I haven't been able to test them yet, will Travis run the tests for those interfaces as well ?
emilsjolander commented 2017-01-12 02:22:47 -08:00 (Migrated from github.com)
Copy Link

Yup it will :) thanks!

Yup it will :) thanks!
arcanis commented 2017-01-12 03:10:17 -08:00 (Migrated from github.com)
Copy Link

Seems good, tests are now passing

Seems good, tests are now passing
arcanis commented 2017-01-12 03:46:24 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander I started looking at how I can implement YGNodeLayoutGetBorder, and actually there will be a bit more work than I thought, since such a function would need to go through the same EDGE_START / EDGE_END check than its two siblings. Would you mind if I implemented it in this PR, since the code will be quite similar?

@emilsjolander I started looking at how I can implement `YGNodeLayoutGetBorder`, and actually there will be a bit more work than I thought, since such a function would need to go through the same `EDGE_START` / `EDGE_END` check than its two siblings. Would you mind if I implemented it in this PR, since the code will be quite similar?
emilsjolander commented 2017-01-12 03:49:21 -08:00 (Migrated from github.com)
Copy Link

@arcanis I would rather it was a PR based on top of this one. Trying to move to smaller pull requests where possible as it makes it much easier to grok the code. Thanks 👍

@arcanis I would rather it was a PR based on top of this one. Trying to move to smaller pull requests where possible as it makes it much easier to grok the code. Thanks 👍
arcanis commented 2017-01-12 03:49:57 -08:00 (Migrated from github.com)
Copy Link

Ok 👍

Ok 👍
emilsjolander (Migrated from github.com) reviewed 2017-01-12 05:28:31 -08:00
emilsjolander (Migrated from github.com) left a comment
Copy Link

Please add tests to YogaNodeTest.cs and YogaNodeTest.java. These will be similar to the tests already there for layoutPadding.

Please add tests to `YogaNodeTest.cs` and `YogaNodeTest.java`. These will be similar to the tests already there for layoutPadding.
csharp/Facebook.Yoga/YogaNode.cs
emilsjolander (Migrated from github.com) commented 2017-01-12 05:25:29 -08:00
Copy Link

Don't add an Obsolete property :p all these will be removed soon enough.

Don't add an Obsolete property :p all these will be removed soon enough.
emilsjolander commented 2017-01-12 05:58:45 -08:00 (Migrated from github.com)
Copy Link

@arcanis Looks good now, thanks!

@arcanis Looks good now, thanks!
facebook-github-bot commented 2017-01-12 05:59:30 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4409399).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#335
No description provided.
Delete Branch "get-margin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?