DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Rename YGUnitPixel to YGPoint... #375

Closed
hartbit wants to merge 1 commits from pixel-to-point into master
pull from: pixel-to-point
merge into: DaddyFrosty:master
Conversation 17 Commits 1 Files Changed 17 +192 -165
hartbit commented 2017-02-03 11:49:03 -08:00 (Migrated from github.com)
Copy Link

...to reflect the modern world we live in with dynamic DPI platforms :)

...to reflect the modern world we live in with dynamic DPI platforms :)
d16r commented 2017-02-03 12:26:02 -08:00 (Migrated from github.com)
Copy Link

Thanks @hartbit. This looks good to me, but I'll leave it upto @emilsjolander to merge it.

Thanks @hartbit. This looks good to me, but I'll leave it upto @emilsjolander to merge it.
emilsjolander commented 2017-02-03 12:43:31 -08:00 (Migrated from github.com)
Copy Link

I'll get to this on monday. Thanks @hartbit !

I'll get to this on monday. Thanks @hartbit !
hartbit commented 2017-02-06 11:13:58 -08:00 (Migrated from github.com)
Copy Link

The build failures seem unrelated...

The build failures seem unrelated...
emilsjolander commented 2017-02-06 11:22:55 -08:00 (Migrated from github.com)
Copy Link

@hartbit agreed. I've had a lot of other stuff to deal with today. I'm going to try to look at both this PR and the failing tests tomorrow or Wednesday. The PR looks good though so don't let this block you from working on the next PR in the chain 👍

@hartbit agreed. I've had a lot of other stuff to deal with today. I'm going to try to look at both this PR and the failing tests tomorrow or Wednesday. The PR looks good though so don't let this block you from working on the next PR in the chain 👍
hartbit commented 2017-02-07 14:50:35 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander No worries :) I have pretty much finished the percentage value adaptation, but I have similar errors and I'd like to know for sure I didn't cause any before opening a PR, so let me know whenever you've figured the current ones out. Thx!

@emilsjolander No worries :) I have pretty much finished the percentage value adaptation, but I have similar errors and I'd like to know for sure I didn't cause any before opening a PR, so let me know whenever you've figured the current ones out. Thx!
emilsjolander commented 2017-02-08 06:39:44 -08:00 (Migrated from github.com)
Copy Link

@hartbit Seems unrelated 👍

@hartbit Seems unrelated 👍
facebook-github-bot commented 2017-02-08 07:36:35 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4528518).
emilsjolander commented 2017-02-08 07:58:33 -08:00 (Migrated from github.com)
Copy Link

Could you squash & rebase. The PR failed to import

Could you squash & rebase. The PR failed to import
hartbit commented 2017-02-08 08:02:35 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander I'm not a git guru :) Can you confirm that those are the steps you want me to take?

  1. git rebase -i HEAD~X Do I really need to squash? I only have one commit?
  2. git rebase master
@emilsjolander I'm not a git guru :) Can you confirm that those are the steps you want me to take? 1. `git rebase -i HEAD~X` Do I really need to squash? I only have one commit? 2. `git rebase master`
emilsjolander commented 2017-02-08 08:06:23 -08:00 (Migrated from github.com)
Copy Link

No need to squash, just rebase (copy pasted same message in multiple PRs :p) I'm not git pro either but have a look at https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

No need to squash, just rebase (copy pasted same message in multiple PRs :p) I'm not git pro either but have a look at https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request
emilsjolander commented 2017-02-08 11:10:46 -08:00 (Migrated from github.com)
Copy Link

@hartbit did you figure it out?

@hartbit did you figure it out?
hartbit commented 2017-02-08 15:44:33 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander I think I did the rebase correctly.

@emilsjolander I think I did the rebase correctly.
emilsjolander commented 2017-02-08 16:10:43 -08:00 (Migrated from github.com)
Copy Link

@hartbit Sadly no. If you look at the file changes and commits in this PR it now contains a lot of other commit. Re-apply your commit to the latest master and push / force push it onto your remote branch.

@hartbit Sadly no. If you look at the file changes and commits in this PR it now contains a lot of other commit. Re-apply your commit to the latest master and push / force push it onto your remote branch.
hartbit commented 2017-02-09 04:09:24 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander Figured it out :)

@emilsjolander Figured it out :)
facebook-github-bot commented 2017-02-09 04:49:31 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4528518).
emilsjolander commented 2017-02-09 04:57:01 -08:00 (Migrated from github.com)
Copy Link

@hartbit FYI I'll rename roundToPointGrid back to roundToPixelGrid before landing. At some point we will want to support point scale factor to round to pixel grid even though input is points.

@hartbit FYI I'll rename `roundToPointGrid` back to `roundToPixelGrid` before landing. At some point we will want to support point scale factor to round to pixel grid even though input is points.
hartbit commented 2017-02-09 08:03:04 -08:00 (Migrated from github.com)
Copy Link

👍🏻

On 9 Feb 2017, at 13:57, Emil Sjölander notifications@github.com wrote:

@hartbit FYI I'll rename roundToPointGrid back to roundToPixelGrid before landing. At some point we will want to support point scale factor to round to pixel grid even though input is points.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

👍🏻 > On 9 Feb 2017, at 13:57, Emil Sjölander <notifications@github.com> wrote: > > @hartbit FYI I'll rename roundToPointGrid back to roundToPixelGrid before landing. At some point we will want to support point scale factor to round to pixel grid even though input is points. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. >

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#375
No description provided.
Delete Branch "pixel-to-point"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?