DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Transfer current layout before calling baseline function #659

Open
woehrl01 wants to merge 1 commits from woehrl01/baseline_transfer into main
pull from: woehrl01/baseline_transfer
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 1 +15 -4
woehrl01 commented 2017-10-15 11:58:37 -07:00 (Migrated from github.com)
Copy Link

This is an alternative fix for #616. This transfers the current layout to the java side before calling the custom baseline function.

This is an alternative fix for #616. This transfers the current layout to the java side before calling the custom baseline function.
emilsjolander commented 2017-11-24 06:39:14 -08:00 (Migrated from github.com)
Copy Link

Seems legit! Thanks!

Seems legit! Thanks!
facebook-github-bot (Migrated from github.com) reviewed 2017-11-24 06:39:25 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D6408056).
emilsjolander commented 2017-11-28 12:08:41 -08:00 (Migrated from github.com)
Copy Link

YogaNodeTest.java:testBaseline is failing after this. could you have a look when you have the time?

YogaNodeTest.java:testBaseline is failing after this. could you have a look when you have the time?
👍 2
woehrl01 commented 2018-04-28 04:24:04 -07:00 (Migrated from github.com)
Copy Link

@emilsjolander, nearly missed this open PR. I updated the code, and it should now pass the test.

@emilsjolander, nearly missed this open PR. I updated the code, and it should now pass the test.
This pull request has changes conflicting with the target branch.
  • java/jni/YGJNI.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin woehrl01/baseline_transfer:woehrl01/baseline_transfer
git checkout woehrl01/baseline_transfer
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Java
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#659
No description provided.
Delete Branch "woehrl01/baseline_transfer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?