DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Update pod spec to 1.8.0, set explicit public header files #726

Closed
a2 wants to merge 2 commits from podspec-1.8.0 into main
pull from: podspec-1.8.0
merge into: DaddyFrosty:main
Conversation 5 Commits 2 Files Changed 2 +6 -5
a2 commented 2018-03-08 09:28:07 -08:00 (Migrated from github.com)
Copy Link
  • Update pod specs to version 1.8.0 (most recent tag)
  • Mark Yoga.h, YGEnums.h, and YGMacros.h as public headers
- Update pod specs to version 1.8.0 (most recent tag) - Mark `Yoga.h`, `YGEnums.h`, and `YGMacros.h` as public headers
❤️ 2
facebook-github-bot commented 2018-03-08 09:28:33 -08:00 (Migrated from github.com)
Copy Link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, **we need you to email [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23726)** with your details so we can update your status.
muukii commented 2018-03-16 02:11:06 -07:00 (Migrated from github.com)
Copy Link

I need this!

I need this!
a2 commented 2018-03-21 09:46:50 -07:00 (Migrated from github.com)
Copy Link

Reiterating this from facebook/rebound-js#49, I sent the CLA to the contact who replied to my email and never heard back. Is it possible for my CLA status to be updated?

Reiterating this from facebook/rebound-js#49, I sent the CLA to the contact who replied to my email and never heard back. Is it possible for my CLA status to be updated?
facebook-github-bot commented 2018-04-02 13:19:45 -07:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
NickGerleman commented 2022-10-11 05:56:43 -07:00 (Migrated from github.com)
Copy Link

It looks like the underlying code has been updated. The podspec is a newer version, and the headers are now public, since the RN build used them (though I'm not sure this is the right boundary to expose).

It looks like the underlying code has been updated. The podspec is a newer version, and the headers are now public, since the RN build used them (though I'm not sure this is the right boundary to expose).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Build and Infrastructure
CLA Signed
YogaKit
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#726
No description provided.
Delete Branch "podspec-1.8.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?