DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix test failure about zero_size_with_child #744

Open
yxping wants to merge 1 commits from yxping/master into main
pull from: yxping/master
merge into: DaddyFrosty:main
Conversation 2 Commits 1 Files Changed 6 +222
yxping commented 2018-03-30 00:22:02 -07:00 (Migrated from github.com)
Copy Link

This change aims to solve the problem that a test about parent has zero width and height which can not pass.
Width and height of the default style should return undefined in gentest/gentest.js .

This change aims to solve the problem that a test about parent has zero width and height which can not pass. Width and height of the default style should return undefined in gentest/gentest.js .
facebook-github-bot commented 2018-03-30 00:22:21 -07:00 (Migrated from github.com)
Copy Link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23744). Thanks!
facebook-github-bot commented 2018-03-30 00:30:03 -07:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
This pull request has changes conflicting with the target branch.
  • csharp/tests/Facebook.Yoga/YGDimensionTest.cs
  • gentest/gentest.js
  • java/tests/com/facebook/yoga/YGDimensionTest.java
  • javascript/tests/Facebook.Yoga/YGDimensionTest.js
  • tests/YGDimensionTest.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin yxping/master:yxping/master
git checkout yxping/master
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Build and Infrastructure
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#744
No description provided.
Delete Branch "yxping/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?