DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix issues with top, bottom, left, right keys in generated React Native code #841

Closed
dhruska wants to merge 2 commits from @dhruska/fix-position-properties into main
pull from: @dhruska/fix-position-properties
merge into: DaddyFrosty:main
Conversation 1 Commits 2 Files Changed 1 +9 -6
dhruska commented 2018-12-20 09:56:30 -08:00 (Migrated from github.com)
Copy Link

This fixes two issues in the generation of React Native code.

  • The top: 10px property is being generated as positionTop: 10px (as are bottom, left and right)
  • positionTop: 10px and positionBottom: 10px is being combined into positionVertical: 10px (as is left and right into horizontal).
This fixes two issues in the generation of React Native code. * The `top: 10px` property is being generated as `positionTop: 10px` (as are bottom, left and right) * `positionTop: 10px` and `positionBottom: 10px` is being combined into `positionVertical: 10px` (as is left and right into horizontal).
NickGerleman commented 2023-12-19 14:54:46 -08:00 (Migrated from github.com)
Copy Link

We are abandoning the old playground in favor of a new one, so closing this out

We are abandoning the old playground in favor of a new one, so closing this out

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#841
No description provided.
Delete Branch "@dhruska/fix-position-properties"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?