DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Carthage support #856

Closed
sjmueller wants to merge 6 commits from master into main
pull from: master
merge into: DaddyFrosty:main
Conversation 5 Commits 6 Files Changed 33 +496 -1165
sjmueller commented 2019-01-25 00:06:17 -08:00 (Migrated from github.com)
Copy Link

This introduces working carthage support for with the latest on master. There are two problems though:

  • it probably breaks cocoapods support
  • the sample project is deleted because I couldn't figure out how to make carthage use the right project

Use github "sjmueller/yoga" "master" in your Cartfile to try it out. Hopefully this serves as a helpful starting point to supporting carthage.

This introduces working carthage support for with the latest on master. There are two problems though: - it probably breaks cocoapods support - the sample project is deleted because I couldn't figure out how to make carthage use the right project Use `github "sjmueller/yoga" "master"` in your `Cartfile` to try it out. Hopefully this serves as a helpful starting point to supporting carthage.
❤️ 2
davidaurelio commented 2019-01-28 13:29:01 -08:00 (Migrated from github.com)
Copy Link

It seems there are a couple of tradeoffs to consider here – I will need some time to check this in detail, sorry :-(

It seems there are a couple of tradeoffs to consider here – I will need some time to check this in detail, sorry :-(
davidaurelio commented 2019-01-28 13:29:13 -08:00 (Migrated from github.com)
Copy Link

And thanks for creating the PR :-)

And thanks for creating the PR :-)
davidaurelio commented 2019-03-04 05:50:18 -08:00 (Migrated from github.com)
Copy Link

Can we do this without having to delete the example and without breaking CocoaPods? I am no iOS expert; ComponentKit’s Carthage build manages to use Yoga today: https://github.com/facebook/componentkit/blob/master/Cartfile.private#L4

Can we do this without having to delete the example and without breaking CocoaPods? I am no iOS expert; ComponentKit’s Carthage build manages to use Yoga today: https://github.com/facebook/componentkit/blob/master/Cartfile.private#L4
davidaurelio commented 2020-06-19 14:57:17 -07:00 (Migrated from github.com)
Copy Link

@SidharthGuglani could you remove me as a reviewer here? Thanks!

@SidharthGuglani could you remove me as a reviewer here? Thanks!
👍 1
NickGerleman commented 2023-01-24 18:30:54 -08:00 (Migrated from github.com)
Copy Link

I don't think we'll want to move forward with this, vs CocoaPods and/or SPM.

I don't think we'll want to move forward with this, vs CocoaPods and/or SPM.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Build and Infrastructure
CLA Signed
YogaKit
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#856
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?