Add "space-evenly" to justify-content documentation and adjusts others #859

2019-01-30T08:19:32-08:00

MoOx commented

2019-01-30 08:19:32 -08:00

(Migrated from github.com)

I wanted to add missing docs for space-evenly, so I simply opened css specs https://drafts.csswg.org/css-align-3/.
While I was on it, I tried to simplify space-around description to not have to compare each space-* to each others.
Finally, I adjusted flex-* and center by just ripping css specs like I did for the other desc.

Feel free to reject some parts of this update. I think some other pages needs the same update.

PS: for the max-len of each lines, I just used prettier (locally on my editor) to avoid having lines too long, I think that could be a good idea to put that for other files too, I can help with that, it's very easy to setup.

I wanted to add missing docs for space-evenly, so I simply opened css specs https://drafts.csswg.org/css-align-3/. While I was on it, I tried to simplify space-around description to not have to compare each space-* to each others. Finally, I adjusted flex-* and center by just ripping css specs like I did for the other desc. Feel free to reject some parts of this update. I think some other pages needs the same update. PS: for the max-len of each lines, I just used prettier (locally on my editor) to avoid having lines too long, I think that could be a good idea to put that for other files too, I can help with that, it's very easy to setup.

davidaurelio commented

2020-06-19 14:56:54 -07:00

(Migrated from github.com)

@SidharthGuglani could you remove me as a reviewer here? Thanks!

NickGerleman (Migrated from github.com) requested changes 2022-12-29 10:27:56 -08:00

NickGerleman (Migrated from github.com) left a comment

There is some language here that seems more ambiguous than before. E.g. Center no longer specifies the axis, or we add specific terms like "main-start" or "cross-start" which are not consistent with other language.

We should do an update pass of the documentation (maybe when I migrate it to Docusaurus), but I think we the previous language here was concise and something we should keep/replicate.

There is some language here that seems more ambiguous than before. E.g. Center no longer specifies the axis, or we add specific terms like "main-start" or "cross-start" which are not consistent with other language. We should do an update pass of the documentation (maybe when I migrate it to Docusaurus), but I think we the previous language here was concise and something we should keep/replicate.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#859