DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

add android sample gradle support #886

Closed
gengjiawen wants to merge 1 commits from android_sample into main
pull from: android_sample
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 32 +39 -13
gengjiawen commented 2019-04-07 07:24:09 -07:00 (Migrated from github.com)
Copy Link

Related issue: https://github.com/facebook/yoga/issues/728.

Related issue: https://github.com/facebook/yoga/issues/728.
Mishkun (Migrated from github.com) reviewed 2019-05-07 08:23:40 -07:00
settings.gradle
@@ -6,6 +6,7 @@
*/
include ':yoga', ':yogacore', ':yoga-layout', ':yoga:proguard-annotations', ':libfb'
include ':android:sample'
Mishkun (Migrated from github.com) commented 2019-05-07 08:23:40 -07:00
Copy Link
include ':yoga-layout:sample'

Or else it fails to sync with the message

ERROR: The modules ['android', 'yoga-layout'] point to the same directory in the file system.
Each module must have a unique path.

because when using relative project naming you implicitly declare an 'android' project

```suggestion include ':yoga-layout:sample' ``` Or else it fails to sync with the message ``` ERROR: The modules ['android', 'yoga-layout'] point to the same directory in the file system. Each module must have a unique path. ``` because when using relative project naming you implicitly declare an 'android' project
gengjiawen (Migrated from github.com) reviewed 2019-05-07 08:27:14 -07:00
settings.gradle
@@ -6,6 +6,7 @@
*/
include ':yoga', ':yogacore', ':yoga-layout', ':yoga:proguard-annotations', ':libfb'
include ':android:sample'
gengjiawen (Migrated from github.com) commented 2019-05-07 08:27:13 -07:00
Copy Link

I don't see the error neither on windows nor on macOS.

I don't see the error neither on windows nor on macOS.
gengjiawen commented 2019-05-14 05:00:00 -07:00 (Migrated from github.com)
Copy Link

@davidaurelio Can you review this too ?

@davidaurelio Can you review this too ?
NickGerleman commented 2023-06-06 15:53:02 -07:00 (Migrated from github.com)
Copy Link

I think @cortinico took this on as part of recent Gradle work. https://github.com/facebook/yoga/blob/main/sample/build.gradle

I think @cortinico took this on as part of recent Gradle work. https://github.com/facebook/yoga/blob/main/sample/build.gradle
❤️ 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Build and Infrastructure
CLA Signed
Documentation
Java
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#886
No description provided.
Delete Branch "android_sample"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?