fix: some subview didn't enable yoga, and crash with NaN frame #933

2019-10-09T03:31:59-07:00

rickytan commented

2019-10-09 03:31:59 -07:00

(Migrated from github.com)

No description provided.

👍 1

facebook-github-bot commented

2019-10-09 03:32:09 -07:00

(Migrated from github.com)

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23933). Thanks!

facebook-github-bot commented

2019-10-12 07:49:57 -07:00

(Migrated from github.com)

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

bolee commented

2021-09-09 01:28:01 -07:00

(Migrated from github.com)

they haven't merge yet?

qxj006 commented

2023-05-28 18:47:30 -07:00

(Migrated from github.com)

they haven't merge yet?

NickGerleman (Migrated from github.com) requested changes 2023-05-30 10:08:57 -07:00

NickGerleman (Migrated from github.com) left a comment

I don't think this fix is correct. YGApplyLayoutToViewHierarchy is not applied to the children of leaf Yoga nodes. Leafs specifically get a measure function which integrates with the backing component.

A UIView backed by non-leaf Yoga Node having non-Yoga children (the way this issue would be encountered), would break other assumptions and not provide a correct layout, so we should not treat it gracefully.

We could replace this with an NSCAssert though for clarity.

I don't think this fix is correct. `YGApplyLayoutToViewHierarchy` is not applied to the children of leaf Yoga nodes. Leafs specifically get a measure function which integrates with the backing component. A UIView backed by non-leaf Yoga Node having non-Yoga children (the way this issue would be encountered), would break other assumptions and not provide a correct layout, so we should not treat it gracefully. We could replace this with an `NSCAssert` though for clarity.

NickGerleman commented

2023-06-13 08:01:19 -07:00

(Migrated from github.com)

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#933