DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

fix: update YogaKitSample to Swift 5 #954

Closed
langyanduan wants to merge 1 commits from fix/example_swift5 into main
pull from: fix/example_swift5
merge into: DaddyFrosty:main
Conversation 3 Commits 1 Files Changed 4 +32 -32
langyanduan commented 2019-11-25 22:22:36 -08:00 (Migrated from github.com)
Copy Link
No description provided.
facebook-github-bot commented 2019-11-25 22:22:46 -08:00 (Migrated from github.com)
Copy Link

Hi langyanduan! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Hi langyanduan! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23954). Thanks!
facebook-github-bot commented 2019-11-25 22:30:23 -08:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
NickGerleman commented 2023-06-06 15:51:33 -07:00 (Migrated from github.com)
Copy Link

Handled as part of 4fc1657f2c

Handled as part of https://github.com/facebook/yoga/commit/4fc1657f2c40655373d93cf439b784fa2eae1779

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Build and Infrastructure
CLA Signed
YogaKit
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#954
No description provided.
Delete Branch "fix/example_swift5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?