feature: support swift package manager #965

2020-01-30T00:16:38-08:00

song-react commented

2020-01-30 00:16:38 -08:00

(Migrated from github.com)

https://github.com/DingSoung/FlexLayout

facebook-github-bot commented

2020-01-30 00:16:47 -08:00

(Migrated from github.com)

Hi DingSoung! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Hi DingSoung! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23965). Thanks!

sjmueller commented

2020-07-11 22:34:35 -07:00

(Migrated from github.com)

Hi @DingSoung thanks for putting this together. Some features of YogaKit are incomplete in the package, for instance there is no ability to use the UIView.yoga property, which is critical to use applyLayout and the configureLayout block. My guess is because the headers and classes within YogaKit/Sources is not included, which contains the gateway UIView+Yoga.h.

I tried reconfiguring your Package.swift to support multiple source directories, but ran into an error about mixed language source files. SPM might have trouble with c++ objc and swift all together, not sure.

Can you take a stab at including the rest of YogaKit in the package?

Hi @DingSoung thanks for putting this together. Some features of YogaKit are incomplete in the package, for instance there is no ability to use the `UIView.yoga` property, which is critical to use `applyLayout` and the `configureLayout` block. My guess is because the headers and classes within `YogaKit/Sources` is not included, which contains the gateway `UIView+Yoga.h`. I tried reconfiguring your `Package.swift` to support multiple source directories, but ran into an error about mixed language source files. SPM might have trouble with c++ objc and swift all together, not sure. Can you take a stab at including the rest of YogaKit in the package?

song-react commented

2020-07-13 18:38:54 -07:00

(Migrated from github.com)

我的想法是分离layout(yoga)和UI(UIKit)

好处1: 前者运行在background thread，后者运行在main thread. main thread 忙的时候，可以减轻它负担。
好处2: 在复杂的页面，可以提前计算好布局，然后构造UI，同时设置位置。

今后我们可以这么写native

let component = View.width(100%).height(80%).backgroundColor(.white).flex(1).justifyContent(.center).subViews(
   Label.text("hello world").fontSize(20).color(.black),
   Image.source("http://xxxx.xxx/src/img.png")
)

我的想法是分离layout(yoga)和UI(UIKit) 好处1: 前者运行在background thread，后者运行在main thread. main thread 忙的时候，可以减轻它负担。好处2: 在复杂的页面，可以提前计算好布局，然后构造UI，同时设置位置。今后我们可以这么写native ```swift let component = View.width(100%).height(80%).backgroundColor(.white).flex(1).justifyContent(.center).subViews( Label.text("hello world").fontSize(20).color(.black), Image.source("http://xxxx.xxx/src/img.png") ) ```

facebook-github-bot commented

2020-12-30 01:18:53 -08:00

(Migrated from github.com)

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

NickGerleman commented

2023-06-13 08:01:46 -07:00

(Migrated from github.com)

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.

song-react commented

2023-06-13 08:02:06 -07:00

(Migrated from github.com)

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#965