Summary: Fixes https://github.com/facebook/yoga/issues/850 https://github.com/facebook/yoga/issues/850 describes a conformance issue where positioning of an absolute child using percentages is not calculated against the correct box size. This takes the fix for that in https://github.com/facebook/yoga/pull/1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal] Pull Request resolved: https://github.com/facebook/yoga/pull/1201 Reviewed By: yungsters Differential Revision: D42282358 Pulled By: NickGerleman fbshipit-source-id: 57c0dd9b0f1c47cb9335ff6e13d44b4646e5fa58
299 lines
10 KiB
JavaScript
299 lines
10 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
// @generated by gentest/gentest.rb from gentest/fixtures/YGPaddingTest.html
|
|
|
|
test("padding_no_size", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPadding(Yoga.EDGE_LEFT, 10);
|
|
root.setPadding(Yoga.EDGE_TOP, 10);
|
|
root.setPadding(Yoga.EDGE_RIGHT, 10);
|
|
root.setPadding(Yoga.EDGE_BOTTOM, 10);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(20);
|
|
expect(root.getComputedHeight()).toBe(20);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(20);
|
|
expect(root.getComputedHeight()).toBe(20);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test("padding_container_match_child", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPadding(Yoga.EDGE_LEFT, 10);
|
|
root.setPadding(Yoga.EDGE_TOP, 10);
|
|
root.setPadding(Yoga.EDGE_RIGHT, 10);
|
|
root.setPadding(Yoga.EDGE_BOTTOM, 10);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setWidth(10);
|
|
root_child0.setHeight(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(30);
|
|
expect(root.getComputedHeight()).toBe(30);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(30);
|
|
expect(root.getComputedHeight()).toBe(30);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test("padding_flex_child", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPadding(Yoga.EDGE_LEFT, 10);
|
|
root.setPadding(Yoga.EDGE_TOP, 10);
|
|
root.setPadding(Yoga.EDGE_RIGHT, 10);
|
|
root.setPadding(Yoga.EDGE_BOTTOM, 10);
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setFlexGrow(1);
|
|
root_child0.setWidth(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(80);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(80);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(80);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test("padding_stretch_child", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPadding(Yoga.EDGE_LEFT, 10);
|
|
root.setPadding(Yoga.EDGE_TOP, 10);
|
|
root.setPadding(Yoga.EDGE_RIGHT, 10);
|
|
root.setPadding(Yoga.EDGE_BOTTOM, 10);
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setHeight(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(80);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(80);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test("padding_center_child", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setJustifyContent(Yoga.JUSTIFY_CENTER);
|
|
root.setAlignItems(Yoga.ALIGN_CENTER);
|
|
root.setPadding(Yoga.EDGE_START, 10);
|
|
root.setPadding(Yoga.EDGE_END, 20);
|
|
root.setPadding(Yoga.EDGE_BOTTOM, 20);
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setWidth(10);
|
|
root_child0.setHeight(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(40);
|
|
expect(root_child0.getComputedTop()).toBe(35);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(50);
|
|
expect(root_child0.getComputedTop()).toBe(35);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test("child_with_padding_align_end", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
|
|
config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setJustifyContent(Yoga.JUSTIFY_FLEX_END);
|
|
root.setAlignItems(Yoga.ALIGN_FLEX_END);
|
|
root.setWidth(200);
|
|
root.setHeight(200);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setPadding(Yoga.EDGE_LEFT, 20);
|
|
root_child0.setPadding(Yoga.EDGE_TOP, 20);
|
|
root_child0.setPadding(Yoga.EDGE_RIGHT, 20);
|
|
root_child0.setPadding(Yoga.EDGE_BOTTOM, 20);
|
|
root_child0.setWidth(100);
|
|
root_child0.setHeight(100);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(200);
|
|
expect(root.getComputedHeight()).toBe(200);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(100);
|
|
expect(root_child0.getComputedTop()).toBe(100);
|
|
expect(root_child0.getComputedWidth()).toBe(100);
|
|
expect(root_child0.getComputedHeight()).toBe(100);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(200);
|
|
expect(root.getComputedHeight()).toBe(200);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(0);
|
|
expect(root_child0.getComputedTop()).toBe(100);
|
|
expect(root_child0.getComputedWidth()).toBe(100);
|
|
expect(root_child0.getComputedHeight()).toBe(100);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|