5496554cbf
Summary: current `MeasureFunc` is stricter than the previous one and when it returns only one dimension object yoga throw `TypeError: Missing field: "height"` or `TypeError: Missing field: "width"` this is a breaking change and `react-pdf` use this feature a lot, so i wanna return the previous behavior back codesandbox with reproduction on `yoga-layout-prebuilt`: https://codesandbox.io/s/yoga-layout-measure-callback-wrong-data-1l9133 Pull Request resolved: https://github.com/facebook/yoga/pull/1219 Reviewed By: NickGerleman Differential Revision: D42778696 Pulled By: jacdebug fbshipit-source-id: 2fb87be74f456ee34273655f2c47f62360001895
65 lines
1.9 KiB
JavaScript
65 lines
1.9 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
test("dont_measure_single_grow_shrink_child", () => {
|
|
const root = Yoga.Node.create();
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const measureCounter = getMeasureCounter(Yoga, null, 100, 100);
|
|
|
|
const root_child0 = Yoga.Node.create();
|
|
root_child0.setMeasureFunc(measureCounter.inc);
|
|
root_child0.setFlexGrow(1);
|
|
root_child0.setFlexShrink(1);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(measureCounter.get()).toBe(0);
|
|
|
|
root.freeRecursive();
|
|
});
|
|
|
|
test("dont_fail_with_incomplete_measure_dimensions", () => {
|
|
const heightOnlyCallback = getMeasureCounter(Yoga, () => ({ height: 10 }));
|
|
const widthOnlyCallback = getMeasureCounter(Yoga, () => ({ width: 10 }));
|
|
const emptyCallback = getMeasureCounter(Yoga, () => ({}));
|
|
|
|
const root = Yoga.Node.create();
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const node1 = Yoga.Node.create();
|
|
const node2 = Yoga.Node.create();
|
|
const node3 = Yoga.Node.create();
|
|
|
|
root.insertChild(node1, root.getChildCount());
|
|
root.insertChild(node2, root.getChildCount());
|
|
root.insertChild(node3, root.getChildCount());
|
|
|
|
node1.setMeasureFunc(heightOnlyCallback.inc);
|
|
node2.setMeasureFunc(widthOnlyCallback.inc);
|
|
node3.setMeasureFunc(emptyCallback.inc);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(heightOnlyCallback.get()).toBe(1);
|
|
expect(widthOnlyCallback.get()).toBe(1);
|
|
expect(emptyCallback.get()).toBe(1);
|
|
|
|
expect(node1.getComputedWidth()).toBe(100);
|
|
expect(node1.getComputedHeight()).toBe(10);
|
|
|
|
expect(node2.getComputedWidth()).toBe(100);
|
|
expect(node2.getComputedHeight()).toBe(0);
|
|
|
|
expect(node3.getComputedWidth()).toBe(100);
|
|
expect(node3.getComputedHeight()).toBe(0);
|
|
|
|
root.freeRecursive();
|
|
});
|