1c8e8d3aec
Summary: GCC 8.3.0 (and possibly all gcc 7+) identified several warnings for signed unsigned integer comparison. With `-Werror` enabled this broke compiling tests. I suspect the warning is related to google/googletest#683. This diff updates those `ASSERT_EQ` calls that attempt to compare signed and unsigned errors by specifically declaring the literals to be unsigned. There is also an issue with Buck where it will not link to pthreads. facebook/buck#1443. Adding a `prebuilt_cxx_library` for pthread fixes that issue and the tests will compile and run. Finally, there was a warning about a missing return after a switch in `InstrumentationTest.cpp`. I added a `return ""` as a default, but it might be better to throw something. Thoughts? Pull Request resolved: https://github.com/facebook/yoga/pull/895 Reviewed By: davidaurelio Differential Revision: D15393082 Pulled By: davidaurelio fbshipit-source-id: 4f13ec2f016af39537c08fb591b188a6a0ed55ce
35 lines
923 B
Python
35 lines
923 B
Python
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
load("//tools/build_defs/oss:yoga_defs.bzl", "YOGA_ROOTS", "subdir_glob", "yoga_cxx_library", "yoga_prebuilt_cxx_library")
|
|
|
|
COMPILER_FLAGS = [
|
|
"-std=c++14",
|
|
"-Wno-missing-prototypes",
|
|
]
|
|
|
|
yoga_prebuilt_cxx_library(
|
|
name = "pthread",
|
|
exported_linker_flags = [
|
|
"-lpthread",
|
|
],
|
|
header_only = True,
|
|
)
|
|
|
|
yoga_cxx_library(
|
|
name = "gtest",
|
|
srcs = glob(["googletest/googletest/src/*.cc"]),
|
|
header_namespace = "",
|
|
exported_headers = subdir_glob([
|
|
("googletest/googletest/include", "**/*.h"),
|
|
("googletest/googletest", "src/*.h"),
|
|
("googletest/googletest", "src/*.cc"),
|
|
]),
|
|
compiler_flags = COMPILER_FLAGS,
|
|
visibility = YOGA_ROOTS,
|
|
deps = [
|
|
":pthread",
|
|
],
|
|
)
|