Reduce warning level of distributed Yoga builds (#1592)
Summary: X-link: https://github.com/facebook/react-native/pull/43405 Pull Request resolved: https://github.com/facebook/yoga/pull/1592 Fixes https://github.com/facebook/yoga/issues/1590 Yoga may be built with a high warning level. This is helpful in letting Yoga be used in more places, and finding defects. We currently set these in the internal BUCK build, the CMake reference build, and the Yoga Standalone (not RN) CocoaPods build. Yoga's reference CMake build and spec are consumed today by users of Yoga, instead of just Yoga developers. Here, it makes more sense to avoid anything that could break compiler-to-compiler compatibility. We default these to a less intense (`-Wall -Werror`). I kept `/W4`, for pragmatic reasons, and since it is relatively standard for MSVC. We continue to build with strict flags on Buck build on Clang. Reviewed By: cortinico Differential Revision: D54735661 fbshipit-source-id: 130e35ac9dcffa2f7e70e48d18770f1275864e2a
This commit is contained in:
committed by
Facebook GitHub Bot
parent
cc2a87d4f9
commit
0d23e07202
@@ -33,8 +33,6 @@ Pod::Spec.new do |spec|
|
||||
'-fexceptions',
|
||||
'-Wall',
|
||||
'-Werror',
|
||||
'-Wextra',
|
||||
'-Wconversion',
|
||||
'-std=c++20',
|
||||
'-fPIC'
|
||||
]
|
||||
|
@@ -33,9 +33,7 @@ add_compile_options(
|
||||
-fexceptions
|
||||
# Enable warnings and warnings as errors
|
||||
-Wall
|
||||
-Wextra
|
||||
-Werror
|
||||
-Wconversion
|
||||
# Disable RTTI
|
||||
$<$<COMPILE_LANGUAGE:CXX>:-fno-rtti>
|
||||
# Use -O2 (prioritize speed)
|
||||
|
Reference in New Issue
Block a user