DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add data-disabled to test fixtures #1286

Closed
NickGerleman wants to merge 1 commits from export-D45723003 into main
pull from: export-D45723003
merge into: DaddyFrosty:main
Conversation 5 Commits 1 Files Changed 52 +1846 -1101
NickGerleman commented 2023-05-10 00:26:02 -07:00 (Migrated from github.com)
Copy Link

Summary:
This can be marked in fixtures to skip a test without commenting it out. We add one more usage of this.

The same functionality existed (unused) before for experiments, which I changed to data-experiments.

Formatting of JS tests changed to be closer to what Prettier would output, and to remove usage of Yoga.UNDEFINED which doesn't existi and just resolves to undefined (this is converted to NaN by the wrapper layer).

Differential Revision: D45723003

Summary: This can be marked in fixtures to skip a test without commenting it out. We add one more usage of this. The same functionality existed (unused) before for `experiments`, which I changed to `data-experiments`. Formatting of JS tests changed to be closer to what Prettier would output, and to remove usage of `Yoga.UNDEFINED` which doesn't existi and just resolves to `undefined` (this is converted to NaN by the wrapper layer). Differential Revision: D45723003
facebook-github-bot commented 2023-05-10 00:27:04 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45723003

This pull request was **exported** from Phabricator. Differential Revision: [D45723003](https://www.internalfb.com/diff/D45723003)
NickGerleman commented 2023-05-10 00:32:45 -07:00 (Migrated from github.com)
Copy Link

cc @nicoburns

cc @nicoburns
facebook-github-bot commented 2023-05-10 21:09:40 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45723003

This pull request was **exported** from Phabricator. Differential Revision: [D45723003](https://www.internalfb.com/diff/D45723003)
facebook-github-bot commented 2023-05-10 22:50:57 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@e769dd97d8.

This pull request has been merged in facebook/yoga@e769dd97d8b2bccceb50fc095e93154ce27cec86.
nicoburns commented 2023-05-14 04:26:33 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman This is awesome. Does this mean that https://github.com/facebook/yoga/pull/1194 is now unblocked? I have some work in progress to export Taffy's test fixtures to Yoga. I'll try to get that into a publishable state, but it might make sense to merge #1194 first, as Taffy has already imported versions of those fixtures and they would therefore be included in an export.

@NickGerleman This is awesome. Does this mean that https://github.com/facebook/yoga/pull/1194 is now unblocked? I have some work in progress to export Taffy's test fixtures to Yoga. I'll try to get that into a publishable state, but it might make sense to merge #1194 first, as Taffy has already imported versions of those fixtures and they would therefore be included in an export.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1286
No description provided.
Delete Branch "export-D45723003"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?